# [PATCH] blame: fix indent of line numbers

2 messages from 2010-03-13 to 2010-03-13. Participants: René Scharfe, Junio C Hamano.
Thread: https://gitlist.dev/t/23008

## René Scharfe, 2010-03-13 10:25

Subject: [PATCH] blame: fix indent of line numbers
Message-ID: <4B9B6808.9070302@lsrfire.ath.cx>
URL: https://gitlist.dev/e/4B9B6808.9070302%40lsrfire.ath.cx

```
Correct the calculation of the number of digits for line counts of the
form 10^n-1 (9, 99, ...) in lineno_width().  This makes blame stop
printing an extra space before the line numbers of files with that many
total lines.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
---
 builtin/blame.c  |    2 +-
 t/t8003-blame.sh |   20 +++++++++++++++++++-
 2 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/builtin/blame.c b/builtin/blame.c
index 10f7eac..fc15863 100644
--- a/builtin/blame.c
+++ b/builtin/blame.c
@@ -1772,7 +1772,7 @@ static int lineno_width(int lines)
 {
 	int i, width;
 
-	for (width = 1, i = 10; i <= lines + 1; width++)
+	for (width = 1, i = 10; i <= lines; width++)
 		i *= 10;
 	return width;
 }
diff --git a/t/t8003-blame.sh b/t/t8003-blame.sh
index 3bbddd0..230143c 100755
--- a/t/t8003-blame.sh
+++ b/t/t8003-blame.sh
@@ -11,7 +11,15 @@ test_expect_success setup '
 	echo B B B B B >two &&
 	echo C C C C C >tres &&
 	echo ABC >mouse &&
-	git add one two tres mouse &&
+	for i in 1 2 3 4 5 6 7 8 9
+	do
+		echo $i
+	done >nine_lines &&
+	for i in 1 2 3 4 5 6 7 8 9 a
+	do
+		echo $i
+	done >ten_lines &&
+	git add one two tres mouse nine_lines ten_lines &&
 	test_tick &&
 	GIT_AUTHOR_NAME=Initial git commit -m Initial &&
 
@@ -167,4 +175,14 @@ test_expect_success 'blame -L with invalid end' '
 	grep "has only 2 lines" errors
 '
 
+test_expect_success 'indent of line numbers, nine lines' '
+	git blame nine_lines >actual &&
+	test $(grep -c "  " actual) = 0
+'
+
+test_expect_success 'indent of line numbers, ten lines' '
+	git blame ten_lines >actual &&
+	test $(grep -c "  " actual) = 9
+'
+
 test_done
-- 
1.7.0.2

```

## Junio C Hamano, 2010-03-13 20:53

Subject: Re: [PATCH] blame: fix indent of line numbers
Message-ID: <7vk4tg7xl9.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vk4tg7xl9.fsf%40alter.siamese.dyndns.org
In-Reply-To: <4B9B6808.9070302@lsrfire.ath.cx>

```
Thanks; embarrassed ;-)

```