threads / patch / 2296

patchStrip any trailing slash on destination argument

Subject: [PATCH] Strip any trailing slash on destination argument

## tl;dr

One message between Nov 1, 2005 and Nov 1, 2005. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Josef Weidendorfer· Nov 1, 2005, 22:46 UTC · lore

Needed because generating a target paths will add another slash. This fixes e.g. "git-mv file dir/", which removed "file" from version control by renaming it to "dir//file", as git-update-index does not accept such paths.

Thanks goes to Ben Lau for noting this bug.
Signed-off-by: Josef Weidendorfer <Josef.Weidendorfer@gmx.de>
---
 git-mv.perl |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

applies-to: e39c96179f2cc5064a0255057b8e8a8863594536 e91e743bdf6d246b279fc7f8f5f7ab733690249b

Show changes to git-mv.perl +2 −0
diff --git a/git-mv.perl b/git-mv.perl
index 17e35b0..a21d87e 100755
--- a/git-mv.perl
+++ b/git-mv.perl
@@ -54,6 +54,8 @@ my ($src, $dst, $base, $dstDir);
 my $argCount = scalar @ARGV;
 if (-d $ARGV[$argCount-1]) {
 	$dstDir = $ARGV[$argCount-1];
+	# remove any trailing slash
+	$dstDir =~ s/\/$//;
 	@srcArgs = @ARGV[0..$argCount-2];
 	
 	foreach $src (@srcArgs) {
---
0.99.9

← back to recent threads