# [PATCH] notes: fix malformed tree entry 2 messages from 2010-02-25 to 2010-02-25. Participants: Junio C Hamano, Johan Herland. Thread: https://gitlist.dev/t/22813 ## Junio C Hamano, 2010-02-25 05:58 Subject: [PATCH] notes: fix malformed tree entry Message-ID: <7vocjdkgaz.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vocjdkgaz.fsf%40alter.siamese.dyndns.org ``` The mode bits for entries in a tree object should be an octal number with minimum number of digits. Do not pad it with 0 to the left. Signed-off-by: Junio C Hamano --- * This comes from 61a7cca (Notes API: write_notes_tree(): Store the notes tree in the database, 2010-02-13) notes.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/notes.c b/notes.c index 3ba3e6d..a4f9926 100644 --- a/notes.c +++ b/notes.c @@ -624,8 +624,8 @@ static void write_tree_entry(struct strbuf *buf, unsigned int mode, const char *path, unsigned int path_len, const unsigned char *sha1) { - strbuf_addf(buf, "%06o %.*s%c", mode, path_len, path, '\0'); - strbuf_add(buf, sha1, 20); + strbuf_addf(buf, "%o %.*s%c", mode, path_len, path, '\0'); + strbuf_add(buf, sha1, 20); } static void tree_write_stack_init_subtree(struct tree_write_stack *tws, -- 1.7.0.227.g2f3f2 ``` ## Johan Herland, 2010-02-25 11:31 Subject: Re: [PATCH] notes: fix malformed tree entry Message-ID: <201002251231.11859.johan@herland.net> URL: https://gitlist.dev/e/201002251231.11859.johan%40herland.net In-Reply-To: <7vocjdkgaz.fsf@alter.siamese.dyndns.org> ``` On Thursday 25 February 2010, Junio C Hamano wrote: > The mode bits for entries in a tree object should be an octal number > with minimum number of digits. Do not pad it with 0 to the left. > > Signed-off-by: Junio C Hamano Acked-by: Johan Herland -- Johan Herland, www.herland.net ```