# Re: [PATCH] commit: quote the user name in the example 5 messages from 2010-02-24 to 2010-02-24. Participants: Junio C Hamano, Matt Kraai, Johannes Sixt. Thread: https://gitlist.dev/t/22786 ## Matt Kraai, 2010-02-24 02:54 Subject: [PATCH] commit: quote the user name in the example Message-ID: <1266980049-5835-1-git-send-email-kraai@ftbfs.org> URL: https://gitlist.dev/e/1266980049-5835-1-git-send-email-kraai%40ftbfs.org ``` If the user runs git config --global user.name Your Name as suggested, user.name will be set to "Your". With this patch, the suggested command will be git config --global user.name 'Your Name' which will set user.name to "Your Name" and hopefully help users avoid the former mistake. Signed-off-by: Matt Kraai --- builtin-commit.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/builtin-commit.c b/builtin-commit.c index 55676fd..1ec89d1 100644 --- a/builtin-commit.c +++ b/builtin-commit.c @@ -41,7 +41,7 @@ static const char implicit_ident_advice[] = "on your username and hostname. Please check that they are accurate.\n" "You can suppress this message by setting them explicitly:\n" "\n" -" git config --global user.name Your Name\n" +" git config --global user.name 'Your Name'\n" " git config --global user.email you@example.com\n" "\n" "If the identity used for this commit is wrong, you can fix it with:\n" -- 1.7.0 ``` ## Junio C Hamano, 2010-02-24 03:00 Subject: Re: [PATCH] commit: quote the user name in the example Message-ID: <7vwry3nxsd.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vwry3nxsd.fsf%40alter.siamese.dyndns.org In-Reply-To: <1266980049-5835-1-git-send-email-kraai@ftbfs.org> ``` Thanks; will queue for 'maint'. ``` ## Johannes Sixt, 2010-02-24 07:49 Subject: Re: [PATCH] commit: quote the user name in the example Message-ID: <4B84DA03.1040809@viscovery.net> URL: https://gitlist.dev/e/4B84DA03.1040809%40viscovery.net In-Reply-To: <1266980049-5835-1-git-send-email-kraai@ftbfs.org> ``` Matt Kraai schrieb: > If the user runs > > git config --global user.name Your Name > > as suggested, user.name will be set to "Your". With this patch, the > suggested command will be > > git config --global user.name 'Your Name' > > which will set user.name to "Your Name" and hopefully help users avoid > the former mistake. Actually, I would prefer that the suggested command is git config --global user.name "Your Name" i.e., with double-quotes, because then the suggestion is also correct for Windows users who run git from CMD: in this environment, single-quotes do not quote, but double-quotes do. -- Hannes ``` ## Matt Kraai, 2010-02-24 14:18 Subject: [PATCH] commit: quote the user name in the example Message-ID: <1267021105-25691-1-git-send-email-kraai@ftbfs.org> URL: https://gitlist.dev/e/1267021105-25691-1-git-send-email-kraai%40ftbfs.org In-Reply-To: <4B84DA03.1040809@viscovery.net> ``` If the user runs git config --global user.name Your Name as suggested, user.name will be set to "Your". With this patch, the suggested command will be git config --global user.name "Your Name" which will set user.name to "Your Name" and hopefully help users avoid the former mistake. Signed-off-by: Matt Kraai --- builtin-commit.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/builtin-commit.c b/builtin-commit.c index 55676fd..46513bf 100644 --- a/builtin-commit.c +++ b/builtin-commit.c @@ -41,7 +41,7 @@ static const char implicit_ident_advice[] = "on your username and hostname. Please check that they are accurate.\n" "You can suppress this message by setting them explicitly:\n" "\n" -" git config --global user.name Your Name\n" +" git config --global user.name \"Your Name\"\n" " git config --global user.email you@example.com\n" "\n" "If the identity used for this commit is wrong, you can fix it with:\n" -- 1.7.0 ``` ## Matt Kraai, 2010-02-24 14:19 Subject: Re: [PATCH] commit: quote the user name in the example Message-ID: <20100224141935.GC2709@ftbfs.org> URL: https://gitlist.dev/e/20100224141935.GC2709%40ftbfs.org In-Reply-To: <4B84DA03.1040809@viscovery.net> ``` On Wed, Feb 24, 2010 at 08:49:23AM +0100, Johannes Sixt wrote: > Actually, I would prefer that the suggested command is > > git config --global user.name "Your Name" > > i.e., with double-quotes, because then the suggestion is also correct for > Windows users who run git from CMD: in this environment, single-quotes do > not quote, but double-quotes do. I've justed submitted a modified version of the patch that uses double-quotes. Thanks for the suggestion. -- Matt http://ftbfs.org/kraai ```