threads / patch / 22706

patchAdded hint about using .gitignore in git status while printing untracked files

Subject: [PATCH] Added hint about using .gitignore in git status while printing untracked files

## tl;dr

4 messages between Feb 18, 2010 and Feb 18, 2010. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Pavan Kumar Sunkara· Feb 18, 2010, 09:48 UTC · lore

Added hint about using .gitignore in git status while printing untracked files Basically, many users don't come to know about .gitignore functionality in their starting stages of git and wonder over how to keep the build or doc files without tracking by git. So, if we add a line saying about gitignore while printing help to add untracked files in git status output, it can be very useful

Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
---
 wt-status.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to wt-status.c +1 −1

diff --git a/wt-status.c b/wt-status.c
index 5807fc3..f17300f 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -100,6 +100,7 @@ static void
wt_status_print_untracked_header(struct wt_status *s)
 	if (!advice_status_hints)
 		return;
 	color_fprintf_ln(s->fp, c, "#   (use \"git add <file>...\" to
include in what will be committed)");
+	color_fprintf_ln(s->fp, c, "#   (add it's path to .gitignore to
intentionally untrack it)");
 	color_fprintf_ln(s->fp, c, "#");
 }

--

Peter Krefting· Feb 18, 2010, 09:59 UTC · re: Pavan Kumar Sunkara · lore

Re: [PATCH] Added hint about using .gitignore in git status while printing untracked files

Pavan Kumar Sunkara:

> +	color_fprintf_ln(s->fp, c, "#   (add it's path to .gitignore to
> intentionally untrack it)");

That should be "its", not "it is".

-- 
\\// Peter - http://www.softwolves.pp.se/

Michael J Gruber· Feb 18, 2010, 11:16 UTC · re: Peter Krefting · lore

Re: [PATCH] Added hint about using .gitignore in git status while printing untracked files

Peter Krefting venit, vidit, dixit 18.02.2010 10:59:

Show 7 quoted lines

> Pavan Kumar Sunkara:
> 
>> +	color_fprintf_ln(s->fp, c, "#   (add it's path to .gitignore to
>> intentionally untrack it)");
> 
> That should be "its", not "it is".
>

Also, an "or" may make things clearer, and "untrack" is wrong: to untrack is to stop tracking, but this is about untracked files. So, how about:

---
 wt-status.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to wt-status.c +1 −1

diff --git a/wt-status.c b/wt-status.c
index 5807fc3..f17300f 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -100,6 +100,7 @@ static void
wt_status_print_untracked_header(struct wt_status *s)
 	if (!advice_status_hints)
 		return;
 	color_fprintf_ln(s->fp, c, "#   (use \"git add <file>...\" to include
in what will be committed)");
+	color_fprintf_ln(s->fp, c, "#   (or add its path to .gitignore to
ignore it permanently)");
 	color_fprintf_ln(s->fp, c, "#");
 }

--

Pavan Kumar Sunkara· Feb 18, 2010, 11:28 UTC · re: Michael J Gruber · lore

Re: [PATCH] Added hint about using .gitignore in git status while printing untracked files

Show 26 quoted lines

>
> Also, an "or" may make things clearer, and "untrack" is wrong: to
> untrack is to stop tracking, but this is about untracked files. So, how
> about:
>
> ---
>  wt-status.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/wt-status.c b/wt-status.c
> index 5807fc3..f17300f 100644
> --- a/wt-status.c
> +++ b/wt-status.c
> @@ -100,6 +100,7 @@ static void
> wt_status_print_untracked_header(struct wt_status *s)
>        if (!advice_status_hints)
>                return;
>        color_fprintf_ln(s->fp, c, "#   (use \"git add <file>...\" to include
> in what will be committed)");
> +       color_fprintf_ln(s->fp, c, "#   (or add its path to .gitignore to
> ignore it permanently)");
>        color_fprintf_ln(s->fp, c, "#");
>  }
>
> --
>

I Think that is good :)

-pavan