# [PATCH] rebase: don't invoke the pager for each commit summary 5 messages from 2010-01-30 to 2010-02-01. Participants: Markus Heidelberg, Johannes Schindelin, Stephen Boyd. Thread: https://gitlist.dev/t/22452 ## Markus Heidelberg, 2010-01-30 16:23 Subject: [PATCH] rebase: don't invoke the pager for each commit summary Message-ID: <1264868617-18547-1-git-send-email-markus.heidelberg@web.de> URL: https://gitlist.dev/e/1264868617-18547-1-git-send-email-markus.heidelberg%40web.de ``` This regression was introduced by commit 0aa958d (rebase: replace antiquated sed invocation, 2010-01-24), which changed the invocation of "git rev-list | sed" to "git log". It can be reproduced by something like this: $ git rebase -s recursive origin/master Signed-off-by: Markus Heidelberg --- git-rebase.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-rebase.sh b/git-rebase.sh index b5d9178..fb4fef7 100755 --- a/git-rebase.sh +++ b/git-rebase.sh @@ -86,7 +86,7 @@ continue_merge () { fi fi test -z "$GIT_QUIET" && - git log --format=%s -1 "$cmt" + GIT_PAGER='' git log --format=%s -1 "$cmt" prev_head=`git rev-parse HEAD^0` # save the resulting commit so we can read-tree on it later -- 1.7.0.rc0.71.g95b6e ``` ## Markus Heidelberg, 2010-01-30 16:46 Subject: Re: [PATCH] rebase: don't invoke the pager for each commit summary Message-ID: <201001301746.13620.markus.heidelberg@web.de> URL: https://gitlist.dev/e/201001301746.13620.markus.heidelberg%40web.de In-Reply-To: ``` Johannes Schindelin, 2010-01-30: > Hi, > > On Sat, 30 Jan 2010, Markus Heidelberg wrote: > > > diff --git a/git-rebase.sh b/git-rebase.sh > > index b5d9178..fb4fef7 100755 > > --- a/git-rebase.sh > > +++ b/git-rebase.sh > > @@ -86,7 +86,7 @@ continue_merge () { > > fi > > fi > > test -z "$GIT_QUIET" && > > - git log --format=%s -1 "$cmt" > > + GIT_PAGER='' git log --format=%s -1 "$cmt" > > Would it not be better 'git --no-pager log [...]'? That was my initial fix, but then I found this in line 519: GIT_PAGER='' git diff --stat --summary "$mb" "$onto" and decided to keep consistency. Don't know. Markus ``` ## Johannes Schindelin, 2010-01-30 16:47 Subject: Re: [PATCH] rebase: don't invoke the pager for each commit summary Message-ID: URL: https://gitlist.dev/e/alpine.DEB.1.00.1001301746200.4985%40pacific.mpi-cbg.de In-Reply-To: <1264868617-18547-1-git-send-email-markus.heidelberg@web.de> ``` Hi, On Sat, 30 Jan 2010, Markus Heidelberg wrote: > diff --git a/git-rebase.sh b/git-rebase.sh > index b5d9178..fb4fef7 100755 > --- a/git-rebase.sh > +++ b/git-rebase.sh > @@ -86,7 +86,7 @@ continue_merge () { > fi > fi > test -z "$GIT_QUIET" && > - git log --format=%s -1 "$cmt" > + GIT_PAGER='' git log --format=%s -1 "$cmt" Would it not be better 'git --no-pager log [...]'? Ciao, Dscho ``` ## Markus Heidelberg, 2010-01-30 16:52 Subject: Re: [PATCH] rebase: don't invoke the pager for each commit summary Message-ID: <201001301752.00804.markus.heidelberg@web.de> URL: https://gitlist.dev/e/201001301752.00804.markus.heidelberg%40web.de In-Reply-To: <201001301746.13620.markus.heidelberg@web.de> ``` Markus Heidelberg, 2010-01-30: > Johannes Schindelin, 2010-01-30: > > Date: Sat, 30 Jan 2010 17:47:11 +0100 (CET) > Date: Sat, 30 Jan 2010 17:46:13 +0100 You should adjust your clock :) Markus ``` ## Stephen Boyd, 2010-02-01 05:39 Subject: Re: [PATCH] rebase: don't invoke the pager for each commit summary Message-ID: <780e0a6b1001312139x1b91bed1q729766c4efde4060@mail.gmail.com> URL: https://gitlist.dev/e/780e0a6b1001312139x1b91bed1q729766c4efde4060%40mail.gmail.com In-Reply-To: <1264868617-18547-1-git-send-email-markus.heidelberg@web.de> ``` On Sat, Jan 30, 2010 at 8:23 AM, Markus Heidelberg wrote: > This regression was introduced by commit 0aa958d (rebase: replace > antiquated sed invocation, 2010-01-24), which changed the invocation of > "git rev-list | sed" to "git log". > > It can be reproduced by something like this: > $ git rebase -s recursive origin/master > > Signed-off-by: Markus Heidelberg > Thanks. Maybe you can use git show too instead of git log -1? ```