# [PATCH] bash: don't offer remote transport helpers as subcommands 2 messages from 2010-01-22 to 2010-01-28. Participants: SZEDER Gábor, Shawn O. Pearce. Thread: https://gitlist.dev/t/22340 ## SZEDER Gábor, 2010-01-22 10:54 Subject: [PATCH] bash: don't offer remote transport helpers as subcommands Message-ID: <1264157691-27187-1-git-send-email-szeder@ira.uka.de> URL: https://gitlist.dev/e/1264157691-27187-1-git-send-email-szeder%40ira.uka.de ``` Since commits a2d725b7 (Use an external program to implement fetching with curl, 2009-08-05) and c9e388bb (Make the "traditionally-supported" URLs a special case, 2009-09-03) remote transport helpers like 'remote-ftp' and 'remote-curl' are offered by the completion script as available subcommands. Not good, since they are helpers, therefore should not be offered, so filter them out. Signed-off-by: SZEDER Gábor --- Maybe maint-worthy? 1.6.5 was the first release with this bug, but nobody complained since then. contrib/completion/git-completion.bash | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 9651720..7def62c 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -568,6 +568,7 @@ __git_list_porcelain_commands () read-tree) : plumbing;; receive-pack) : plumbing;; reflog) : plumbing;; + remote-*) : transport;; repo-config) : deprecated;; rerere) : plumbing;; rev-list) : plumbing;; -- 1.6.6.1.361.gc5121 ``` ## Shawn O. Pearce, 2010-01-28 15:19 Subject: Re: [PATCH] bash: don't offer remote transport helpers as subcommands Message-ID: <20100128151951.GB20185@spearce.org> URL: https://gitlist.dev/e/20100128151951.GB20185%40spearce.org In-Reply-To: <1264157691-27187-1-git-send-email-szeder@ira.uka.de> ``` SZEDER G??bor wrote: > Since commits a2d725b7 (Use an external program to implement fetching > with curl, 2009-08-05) and c9e388bb (Make the > "traditionally-supported" URLs a special case, 2009-09-03) remote > transport helpers like 'remote-ftp' and 'remote-curl' are offered by the > completion script as available subcommands. Not good, since they are > helpers, therefore should not be offered, so filter them out. > > Signed-off-by: SZEDER G??bor > --- > > Maybe maint-worthy? 1.6.5 was the first release with this bug, but > nobody complained since then. Yup, should be in maint. Acked-by: Shawn O. Pearce > contrib/completion/git-completion.bash | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash > index 9651720..7def62c 100755 > --- a/contrib/completion/git-completion.bash > +++ b/contrib/completion/git-completion.bash > @@ -568,6 +568,7 @@ __git_list_porcelain_commands () > read-tree) : plumbing;; > receive-pack) : plumbing;; > reflog) : plumbing;; > + remote-*) : transport;; > repo-config) : deprecated;; > rerere) : plumbing;; > rev-list) : plumbing;; > -- > 1.6.6.1.361.gc5121 -- Shawn. ```