# [PATCH 4/4] msvc: Add a definition of NORETURN compatible with msvc compiler 4 messages from 2010-01-20 to 2010-01-23. Participants: Ramsay Jones, Erik Faye-Lund, Sebastian Schuberth. Thread: https://gitlist.dev/t/22315 ## Ramsay Jones, 2010-01-20 19:45 Subject: [PATCH 4/4] msvc: Add a definition of NORETURN compatible with msvc compiler Message-ID: <4B575D48.9070508@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/4B575D48.9070508%40ramsay1.demon.co.uk ``` Signed-off-by: Ramsay Jones --- I thought that Erik had already submitted this patch along with those that resulted in commits a4f3131c and 18660bc9. However, I don't seem to be able to find it anywhere! (maybe I only imagined it). If you find Erik's patch, please apply that instead... ATB, Ramsay Jones git-compat-util.h | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/git-compat-util.h b/git-compat-util.h index 5c59687..6efea29 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -177,6 +177,9 @@ extern char *gitbasename(char *); #ifdef __GNUC__ #define NORETURN __attribute__((__noreturn__)) #define NORETURN_PTR __attribute__((__noreturn__)) +#elif defined(_MSC_VER) +#define NORETURN __declspec(noreturn) +#define NORETURN_PTR #else #define NORETURN #define NORETURN_PTR -- 1.6.6 ``` ## Erik Faye-Lund, 2010-01-20 21:45 Subject: Re: [PATCH 4/4] msvc: Add a definition of NORETURN compatible with msvc compiler Message-ID: <40aa078e1001201345p1cf9dfbbm651f1ba7244a340f@mail.gmail.com> URL: https://gitlist.dev/e/40aa078e1001201345p1cf9dfbbm651f1ba7244a340f%40mail.gmail.com In-Reply-To: <4B575D48.9070508@ramsay1.demon.co.uk> ``` On Wed, Jan 20, 2010 at 8:45 PM, Ramsay Jones wrote: > > Signed-off-by: Ramsay Jones > --- > > I thought that Erik had already submitted this patch along with > those that resulted in commits a4f3131c and 18660bc9. However, I > don't seem to be able to find it anywhere! (maybe I only imagined > it). > > If you find Erik's patch, please apply that instead... > I don't think I ever sent one - I haven't bothered to set up msvc for git compilation, so I only did the preparation (and I think I sent a comment about how it could be done). So, thanks for following it up! :) -- Erik "kusma" Faye-Lund ``` ## Ramsay Jones, 2010-01-22 19:35 Subject: Re: [PATCH 4/4] msvc: Add a definition of NORETURN compatible with msvc compiler Message-ID: <4B59FE06.5010506@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/4B59FE06.5010506%40ramsay1.demon.co.uk In-Reply-To: <40aa078e1001201345p1cf9dfbbm651f1ba7244a340f@mail.gmail.com> ``` Erik Faye-Lund wrote: > On Wed, Jan 20, 2010 at 8:45 PM, Ramsay Jones > wrote: >> Signed-off-by: Ramsay Jones >> --- >> >> I thought that Erik had already submitted this patch along with >> those that resulted in commits a4f3131c and 18660bc9. However, I >> don't seem to be able to find it anywhere! (maybe I only imagined >> it). >> >> If you find Erik's patch, please apply that instead... > > I don't think I ever sent one - I haven't bothered to set up msvc for > git compilation, so I only did the preparation (and I think I sent a > comment about how it could be done). Ah, so maybe it's this comment that I (mis-)remembered then! (yeah, my memory is not what it used to be ;-)). Thanks for doing the preparation work! ATB, Ramsay Jones ``` ## Sebastian Schuberth, 2010-01-23 00:18 Subject: Re: [PATCH 4/4] msvc: Add a definition of NORETURN compatible with msvc compiler Message-ID: <4B5A4068.8010004@gmail.com> URL: https://gitlist.dev/e/4B5A4068.8010004%40gmail.com In-Reply-To: <4B575D48.9070508@ramsay1.demon.co.uk> ``` On 20.01.2010 20:45, Ramsay Jones wrote: > Signed-off-by: Ramsay Jones Acked-by: Sebastian Schuberth -- Sebastian Schuberth ```