[PATCH] Add `format.to` configuration variable.

Steven Drake· Jan 13, 2010, 07:55 UTC · lore

Signed-off-by: Steven Drake <sdrake@xnet.co.nz>
---
This email was address using this new configuration variable.
---
 builtin-log.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

Show changes to builtin-log.c +7 −0

diff --git a/builtin-log.c b/builtin-log.c
index 41b6df4..a608c3d 100644
--- a/builtin-log.c
+++ b/builtin-log.c
@@ -501,6 +501,13 @@ static int git_format_config(const char *var, const char *value, void *cb)
 	}
 	if (!strcmp(var, "format.suffix"))
 		return git_config_string(&fmt_patch_suffix, var, value);
+	if (!strcmp(var, "format.to")) {
+		if (!value)
+			return config_error_nonbool(var);
+		ALLOC_GROW(extra_to, extra_to_nr + 1, extra_to_alloc);
+		extra_to[extra_to_nr++] = xstrdup(value);
+		return 0;
+	}
 	if (!strcmp(var, "format.cc")) {
 		if (!value)
 			return config_error_nonbool(var);

-- 
1.6.6.85.ga4c31

Johannes Sixt· Jan 13, 2010, 08:20 UTC · re: Steven Drake · lore

Re: [PATCH] Add `format.to` configuration variable.

You submitted a number of patches in the last hours, but you gave *zero* motivation for them, i.e., the commit messages lack words about *why* the changes are good (and what they are good for).

This particular patch lacks documentation, in particular, it's worth to mention that format.to could be given more than once.

-- Hannes

patchAdd `format.to` configuration variable.