# [PATCH] Add `commit.signoff` configuration variable. 3 messages from 2010-01-13 to 2010-01-13. Participants: Steven Drake, Junio C Hamano. Thread: https://gitlist.dev/t/22190 ## Steven Drake, 2010-01-13 03:36 Subject: [PATCH] Add `commit.signoff` configuration variable. Message-ID: URL: https://gitlist.dev/e/alpine.LNX.2.00.1001131635510.16395%40vqena.qenxr.bet.am ``` Signed-off-by: Steven Drake --- Documentation/config.txt | 4 ++++ Documentation/git-commit.txt | 2 +- builtin-commit.c | 4 ++++ 3 files changed, 9 insertions(+), 1 deletions(-) diff --git a/Documentation/config.txt b/Documentation/config.txt index 23a965e..dd261cf 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -712,6 +712,10 @@ color.ui:: terminal. When more specific variables of color.* are set, they always take precedence over this setting. Defaults to false. +commit.signoff:: + Add Signed-off-by line by the committer at the end of the commit + log message. + commit.template:: Specify a file to use as the template for new commit messages. "{tilde}/" is expanded to the value of `$HOME` and "{tilde}user/" to the diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt index c97c151..5a977b6 100644 --- a/Documentation/git-commit.txt +++ b/Documentation/git-commit.txt @@ -114,7 +114,7 @@ OPTIONS -s:: --signoff:: Add Signed-off-by line by the committer at the end of the commit - log message. + log message. This overrides the `commit.signoff` configuration variable. -n:: --no-verify:: diff --git a/builtin-commit.c b/builtin-commit.c index 3dfcd77..db90e7a 100644 --- a/builtin-commit.c +++ b/builtin-commit.c @@ -1093,6 +1093,10 @@ static int git_commit_config(const char *k, const char *v, void *cb) if (!strcmp(k, "commit.template")) return git_config_pathname(&template_file, k, v); + if (!strcmp(k, "commit.signoff")) { + signoff = git_config_bool(k, v); + return 0; + } return git_status_config(k, v, s); } -- 1.6.4 ``` ## Steven Drake, 2010-01-13 04:36 Subject: Re: [PATCH] Add `commit.signoff` configuration variable. Message-ID: URL: https://gitlist.dev/e/alpine.LNX.2.00.1001131735520.22756%40vqena.qenxr.bet.am In-Reply-To: ``` On Wed, 13 Jan 2010, Steven Drake wrote: > Signed-off-by: Steven Drake I ment to make a note with that patch that the commit message Signed-off-by was added using using the `commit.signoff` feature. -- Steven 1: Linux - will work for fish. 2: The Linux penguin - looks stuffed to the brim with herring. ( make your own conclusions ) ``` ## Junio C Hamano, 2010-01-13 08:30 Subject: Re: [PATCH] Add `commit.signoff` configuration variable. Message-ID: <7v1vhuquea.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7v1vhuquea.fsf%40alter.siamese.dyndns.org In-Reply-To: ``` You need to defend this one better, in fact a *lot* better, than other ones. See http://thread.gmane.org/gmane.comp.version-control.git/32503/focus=32522 http://thread.gmane.org/gmane.comp.version-control.git/103939/focus=104207 for starters. Your justifications should address all the points raised in previous threads. ```