threads / patch / 22142

patchhg-to-git: fix COMMITTER type-o

Subject: [PATCH] hg-to-git: fix COMMITTER type-o

## tl;dr

3 messages between Jan 9, 2010 and Jan 13, 2010. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Bart Trojanowski· Jan 9, 2010, 00:54 UTC · lore

This script passes the author and committer to git-commit via environment variables, but it was missing the seccond T of COMMITTER in a few places.

Signed-off-by: Bart Trojanowski <bart@jukie.net>
---
 contrib/hg-to-git/hg-to-git.py |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
Show changes to contrib/hg-to-git/hg-to-git.py +4 −4
diff --git a/contrib/hg-to-git/hg-to-git.py b/contrib/hg-to-git/hg-to-git.py
index 2a6839d..854cd94 100755
--- a/contrib/hg-to-git/hg-to-git.py
+++ b/contrib/hg-to-git/hg-to-git.py
@@ -59,14 +59,14 @@ def getgitenv(user, date):
     elems = re.compile('(.*?)\s+<(.*)>').match(user)
     if elems:
         env += 'export GIT_AUTHOR_NAME="%s" ;' % elems.group(1)
-        env += 'export GIT_COMMITER_NAME="%s" ;' % elems.group(1)
+        env += 'export GIT_COMMITTER_NAME="%s" ;' % elems.group(1)
         env += 'export GIT_AUTHOR_EMAIL="%s" ;' % elems.group(2)
-        env += 'export GIT_COMMITER_EMAIL="%s" ;' % elems.group(2)
+        env += 'export GIT_COMMITTER_EMAIL="%s" ;' % elems.group(2)
     else:
         env += 'export GIT_AUTHOR_NAME="%s" ;' % user
-        env += 'export GIT_COMMITER_NAME="%s" ;' % user
+        env += 'export GIT_COMMITTER_NAME="%s" ;' % user
         env += 'export GIT_AUTHOR_EMAIL= ;'
-        env += 'export GIT_COMMITER_EMAIL= ;'
+        env += 'export GIT_COMMITTER_EMAIL= ;'
 
     env += 'export GIT_AUTHOR_DATE="%s" ;' % date
     env += 'export GIT_COMMITTER_DATE="%s" ;' % date
-- 
1.6.6.2.g9ad4f53
Stelian Pop· Jan 12, 2010, 11:16 UTC · re: Bart Trojanowski · lore

Re: [PATCH] hg-to-git: fix COMMITTER type-o

Hi Bart,
On Fri, Jan 08, 2010 at 07:54:39PM -0500, Bart Trojanowski wrote:
> This script passes the author and committer to git-commit via environment
> variables, but it was missing the seccond T of COMMITTER in a few places.
> 
> Signed-off-by: Bart Trojanowski <bart@jukie.net>
FWIW:
	Acked-by: Stelian Pop <stelian@popies.net>
Thanks!
Stelian.
-- 
Stelian Pop <stelian@popies.net>

← back to recent threads