threads / discuss / 22057

65c042d4 broke `remote update' without named group

Subject: 65c042d4 broke `remote update' without named group

## tl;dr

3 messages between Dec 29, 2009 and Jan 1, 2010.

replies: 2people: 3as markdown or json

YONETANI Tomokazu· Dec 29, 2009, 23:49 UTC · lore
Hello.
It seems that with 65c042d4 (and v1.6.6), git-remote update without
specifying a group on the command line ends up with the following error
message if you define remotes.default in the config file:
  $ git remote update
  fatal: 'default' does not appear to be a git repository
  fatal: The remote end hung up unexpectedly

The document still says that when you don't specify the named group, remotes.default in the configuration will get used, so this should work (and it used to work with v1.6.4).

After the commit 65c042d4, the commands are translated as follows:
  $ git remote update
  ==> git-fetch default		(with remotes.default defined)		NG
  ==> git-fetch --all		(without remotes.default defined)	OK
  $ git remote update default
  ==> git-fetch --multiple default					OK

So just adding "--multiple" in front of "default" in the first case above should fix it.

Best regards, YONETANI Tomokazu.

Tay Ray Chuan· Jan 1, 2010, 09:00 UTC · re: YONETANI Tomokazu · lore

Re: 65c042d4 broke `remote update' without named group

Hi,
On Wed, Dec 30, 2009 at 7:49 AM, YONETANI Tomokazu <qhwt+git@les.ath.cx> wrote:
Show 22 quoted lines
> Hello.
> It seems that with 65c042d4 (and v1.6.6), git-remote update without
> specifying a group on the command line ends up with the following error
> message if you define remotes.default in the config file:
>  $ git remote update
>  fatal: 'default' does not appear to be a git repository
>  fatal: The remote end hung up unexpectedly
>
> The document still says that when you don't specify the named group,
> remotes.default in the configuration will get used, so this should work
> (and it used to work with v1.6.4).
>
> After the commit 65c042d4, the commands are translated as follows:
>  $ git remote update
>  ==> git-fetch default         (with remotes.default defined)          NG
>  ==> git-fetch --all           (without remotes.default defined)       OK
>
>  $ git remote update default
>  ==> git-fetch --multiple default                                      OK
>
> So just adding "--multiple" in front of "default" in the first case
> above should fix it.

Björn (added to Cc list), you seem to have been the main author of 'bg/fetch-multi', do you have any idea on this?

-- 
Cheers,
Ray Chuan
Björn Gustavsson· Jan 1, 2010, 09:14 UTC · re: Tay Ray Chuan · lore

Re: 65c042d4 broke `remote update' without named group

2010/1/1 Tay Ray Chuan <rctay89@gmail.com>:
> Björn (added to Cc list), you seem to have been the main author of
> 'bg/fetch-multi', do you have any idea on this?

Yes. I have fixed the problem and my correction is included in the latest 'pu' (bg/maint-remote-update-default).

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB

← back to recent threads