# [PATCH 2/2] git-svn: Move setting of svn.authorsfile in clone to between init and fetch 3 messages from 2009-12-08 to 2009-12-09. Participants: Alex Vandiver, Eric Wong. Thread: https://gitlist.dev/t/21911 ## Alex Vandiver, 2009-12-08 20:54 Subject: [PATCH 1/2] git-svn: Set svn.authorsfile to an absolute path when cloning Message-ID: <1260305651-11111-1-git-send-email-alex@chmrr.net> URL: https://gitlist.dev/e/1260305651-11111-1-git-send-email-alex%40chmrr.net ``` If --authors-file is passed a relative path, cloning will work, but future `git svn fetch`es will fail to locate the authors file correctly. Thus, use File::Spec->rel2abs to determine an absolute path for the authors file before setting it. Signed-off-by: Alex Vandiver --- git-svn.perl | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/git-svn.perl b/git-svn.perl index 957d44e..cf5e75e 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -392,9 +392,11 @@ sub cmd_clone { $path = $url; } $path = basename($url) if !defined $path || !length $path; + my $authors_absolute = $_authors ? File::Spec->rel2abs($_authors) : ""; cmd_init($url, $path); Git::SVN::fetch_all($Git::SVN::default_repo_id); - command_oneline('config', 'svn.authorsfile', $_authors) if $_authors; + command_oneline('config', 'svn.authorsfile', $authors_absolute) + if $_authors; } sub cmd_init { -- 1.6.6.rc0.360.gc408 ``` ## Alex Vandiver, 2009-12-08 20:54 Subject: [PATCH 2/2] git-svn: Move setting of svn.authorsfile in clone to between init and fetch Message-ID: <1260305651-11111-2-git-send-email-alex@chmrr.net> URL: https://gitlist.dev/e/1260305651-11111-2-git-send-email-alex%40chmrr.net In-Reply-To: <1260305651-11111-1-git-send-email-alex@chmrr.net> ``` If a clone errors out because of a missing author, or user interrupt, this allows `git svn fetch` to resume seamlessly, rather than forcing the user to re-provide the path to the authors file. Signed-off-by: Alex Vandiver --- git-svn.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-svn.perl b/git-svn.perl index cf5e75e..3c3e0e0 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -394,9 +394,9 @@ sub cmd_clone { $path = basename($url) if !defined $path || !length $path; my $authors_absolute = $_authors ? File::Spec->rel2abs($_authors) : ""; cmd_init($url, $path); - Git::SVN::fetch_all($Git::SVN::default_repo_id); command_oneline('config', 'svn.authorsfile', $authors_absolute) if $_authors; + Git::SVN::fetch_all($Git::SVN::default_repo_id); } sub cmd_init { -- 1.6.6.rc0.360.gc408 ``` ## Eric Wong, 2009-12-09 04:44 Subject: Re: [PATCH 2/2] git-svn: Move setting of svn.authorsfile in clone to between init and fetch Message-ID: <20091209044403.GA22566@dcvr.yhbt.net> URL: https://gitlist.dev/e/20091209044403.GA22566%40dcvr.yhbt.net In-Reply-To: <1260305651-11111-2-git-send-email-alex@chmrr.net> ``` Alex Vandiver wrote: > If a clone errors out because of a missing author, or user interrupt, > this allows `git svn fetch` to resume seamlessly, rather than forcing > the user to re-provide the path to the authors file. Thanks Alex, I shortened the subject on this one, acked the series and pushed to git://git.bogomips.org/git-svn Alex Vandiver (2): git-svn: Set svn.authorsfile to an absolute path when cloning git-svn: set svn.authorsfile earlier when cloning -- Eric Wong ```