# [PATCH] Cast &cp to eliminate a compile-time warning on FreeBSD 8-STABLE. 3 messages from 2009-12-04 to 2009-12-05. Participants: James P. Howard, II, Jeff King. Thread: https://gitlist.dev/t/21866 ## James P. Howard, II, 2009-12-04 23:12 Subject: [PATCH] Cast &cp to eliminate a compile-time warning on FreeBSD 8-STABLE. Message-ID: <1259968322-66072-1-git-send-email-jh@jameshoward.us> URL: https://gitlist.dev/e/1259968322-66072-1-git-send-email-jh%40jameshoward.us ``` Signed-off-by: James P. Howard, II --- utf8.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/utf8.c b/utf8.c index 7ddff23..a6cc280 100644 --- a/utf8.c +++ b/utf8.c @@ -449,7 +449,7 @@ char *reencode_string(const char *in, const char *out_encoding, const char *in_e cp = (iconv_ibp)in; while (1) { - size_t cnt = iconv(conv, &cp, &insz, &outpos, &outsz); + size_t cnt = iconv(conv, (const char **)&cp, &insz, &outpos, &outsz); if (cnt == -1) { size_t sofar; -- 1.6.5.3 ``` ## Jeff King, 2009-12-05 16:14 Subject: Re: [PATCH] Cast &cp to eliminate a compile-time warning on FreeBSD 8-STABLE. Message-ID: <20091205161405.GA9272@sigill.intra.peff.net> URL: https://gitlist.dev/e/20091205161405.GA9272%40sigill.intra.peff.net In-Reply-To: <1259968322-66072-1-git-send-email-jh@jameshoward.us> ``` On Fri, Dec 04, 2009 at 06:12:02PM -0500, James P. Howard, II wrote: > --- a/utf8.c > +++ b/utf8.c > @@ -449,7 +449,7 @@ char *reencode_string(const char *in, const char *out_encoding, const char *in_e > cp = (iconv_ibp)in; > > while (1) { > - size_t cnt = iconv(conv, &cp, &insz, &outpos, &outsz); > + size_t cnt = iconv(conv, (const char **)&cp, &insz, &outpos, &outsz); > > if (cnt == -1) { > size_t sofar; Aren't you now introducing a warning for all of the other platforms which take a "char **"? Should you instead just be building with OLD_ICONV=Yes on your platform? See commit fd547a9 for details. -Peff ``` ## James P. Howard, II, 2009-12-05 23:03 Subject: Re: [PATCH] Cast &cp to eliminate a compile-time warning on FreeBSD 8-STABLE. Message-ID: <20091205230350.GA3810@thermopylae.local> URL: https://gitlist.dev/e/20091205230350.GA3810%40thermopylae.local In-Reply-To: <20091205161405.GA9272@sigill.intra.peff.net> ``` On Sat, Dec 05, 2009 at 11:14:05AM -0500, Jeff King wrote: > On Fri, Dec 04, 2009 at 06:12:02PM -0500, James P. Howard, II wrote: > > > --- a/utf8.c > > +++ b/utf8.c > > @@ -449,7 +449,7 @@ char *reencode_string(const char *in, const char *out_encoding, const char *in_e > > cp = (iconv_ibp)in; > > > > while (1) { > > - size_t cnt = iconv(conv, &cp, &insz, &outpos, &outsz); > > + size_t cnt = iconv(conv, (const char **)&cp, &insz, &outpos, &outsz); > > > > if (cnt == -1) { > > size_t sofar; > > Aren't you now introducing a warning for all of the other platforms > which take a "char **"? Should you instead just be building with > OLD_ICONV=Yes on your platform? See commit fd547a9 for details. Yes, and it was brought to my attention within 10 minutes of my first post. James -- James P. Howard, II, MPA MBCS jh@jameshoward.us ```