# [PATCH] t4014-format-patch: do not assume 'test' is available as non-builtin

1 messages from 2009-11-23 to 2009-11-23. Participants: Johannes Sixt.
Thread: https://gitlist.dev/t/21725

## Johannes Sixt, 2009-11-23 09:35

Subject: [PATCH] t4014-format-patch: do not assume 'test' is available as non-builtin
Message-ID: <4B0A5779.4050401@viscovery.net>
URL: https://gitlist.dev/e/4B0A5779.4050401%40viscovery.net

```
From: Johannes Sixt <j6t@kdbg.org>

One test case used 'xargs test', which assumes that 'test' is available
as external program. At least on MinGW it is not.

Moreover, 'git format-patch' was invoked in a pipeline, but not as the
last command. Rewrite the test case to catch breakage in 'git format-patch'
as well.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 t/t4014-format-patch.sh |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
index 5689d59..7f267f9 100755
--- a/t/t4014-format-patch.sh
+++ b/t/t4014-format-patch.sh
@@ -549,9 +549,7 @@ test_expect_success 'options no longer allowed for format-patch' '
 	test_cmp expect.check output'

 test_expect_success 'format-patch --numstat should produce a patch' '
-	git format-patch --numstat --stdout master..side |
-	grep "^diff --git a/" |
-	wc -l |
-	xargs test 6 = '
+	git format-patch --numstat --stdout master..side > output &&
+	test 6 = $(grep "^diff --git a/" output | wc -l)'

 test_done
-- 
1.6.6.rc0.1059.gdce25

```