threads / patch / 21721

patchbisect: simplify calling visualizer using '--bisect' option

Subject: [PATCH] bisect: simplify calling visualizer using '--bisect' option

## tl;dr

One message between Nov 23, 2009 and Nov 23, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Christian Couder· Nov 23, 2009, 04:16 UTC · lore

In commit ad3f9a7 (Add '--bisect' revision machinery argument) the '--bisect' option was added to easily pass bisection refs to commands using the revision machinery.

So it is now shorter and safer to use the new '--bisect' revision machinery option, than to compute the refs that we must pass.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 git-bisect.sh |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
	This patch was previously sent in an RFC series aimed at
	using '--bisect-refs' instead of '--bisect' as the revision
	machinery bisect option.
Show changes to git-bisect.sh +1 −2
diff --git a/git-bisect.sh b/git-bisect.sh
index 8b3c585..a5ea843 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -300,8 +300,7 @@ bisect_visualize() {
 		esac
 	fi
 
-	not=$(git for-each-ref --format='%(refname)' "refs/bisect/good-*")
-	eval '"$@"' refs/bisect/bad --not $not -- $(cat "$GIT_DIR/BISECT_NAMES")
+	eval '"$@"' --bisect -- $(cat "$GIT_DIR/BISECT_NAMES")
 }
 
 bisect_reset() {
-- 
1.6.5.1.gaf97d

← back to recent threads