threads / patch / 21716

patchFix truncated usage messages

Subject: [PATCH] Fix truncated usage messages

## tl;dr

One message between Nov 22, 2009 and Nov 22, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Björn Gustavsson· Nov 22, 2009, 21:19 UTC · lore

The usage messages for some commands (such as 'git diff-tree') are truncated because they don't fit in a fixed buffer of 1024 bytes.

It would be tempting to eliminate the buffer and the problem once and for all by doing the output in three steps, but doing so could (according to commit d048a96e) increase the likelyhood of messing up the display.

So we just increase the size of the buffer.
Signed-off-by: Björn Gustavsson <bgustavsson@gmail.com>
---
 usage.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to usage.c +1 −1
diff --git a/usage.c b/usage.c
index e307e01..79856a2 100644
--- a/usage.c
+++ b/usage.c
@@ -7,7 +7,7 @@
 
 static void report(const char *prefix, const char *err, va_list params)
 {
-	char msg[1024];
+	char msg[4096];
 	vsnprintf(msg, sizeof(msg), err, params);
 	fprintf(stderr, "%s%s\n", prefix, msg);
 }
-- 
1.6.5.3.298.g39add

← back to recent threads