threads / patch / 21699

v2git-count-objects: Fix a disk-space under-estimate on Cygwin

Subject: [PATCH v2] git-count-objects: Fix a disk-space under-estimate on Cygwin

## tl;dr

One message between Nov 20, 2009 and Nov 20, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Ramsay Jones· Nov 20, 2009, 23:27 UTC · lore

On Cygwin, the st_blocks field in 'struct stat' counts in blocks of st_blksize bytes. At least on NTFS, the st_blksize field is not 512 bytes, as required by the code, which leads to an under estimate of the disk-space used.

Setting the build variable NO_ST_BLOCKS_IN_STRUCT_STAT, switches to an algorithm that only uses the st_size field to compute the disk-space estimate.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Changed since v1:
    - a commit message!
    - removed comment.

ATB, Ramsay Jones

 Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Show changes to Makefile +1 −0
diff --git a/Makefile b/Makefile
index 5d5976f..8902dba 100644
--- a/Makefile
+++ b/Makefile
@@ -783,6 +783,7 @@ ifeq ($(uname_O),Cygwin)
 	NO_FAST_WORKING_DIRECTORY = UnfortunatelyYes
 	NO_TRUSTABLE_FILEMODE = UnfortunatelyYes
 	OLD_ICONV = UnfortunatelyYes
+	NO_ST_BLOCKS_IN_STRUCT_STAT = YesPlease
 	# There are conflicting reports about this.
 	# On some boxes NO_MMAP is needed, and not so elsewhere.
 	# Try commenting this out if you suspect MMAP is more efficient
-- 
1.6.5

← back to recent threads