patchbash completion: add space between branch name and status flags

Hello Shawn, hello git list members,

Wouldn't it improve the readability of the bash prompt, if there would be a space between the branch name and the status flags (dirty, stash, untracked)?

Signed-off-by: Roman Fietze <roman.fietze@telemotive.de>
---
 contrib/completion/git-completion.bash |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

Roman Fietze <roman.fietze@telemotive.de> writes:

Perhaps.

I think this line and the two changes to printf below is a big improvement (unless we are using f for something else---I didn't look). But I think the next line is wrong.

The $r string is designed to be used as suffix from the beginning and always has "|" in front of it as a delimiter, so if there is no w/i/s/u (and I suspect many people do not use GIT_PS1_SHOWDIRTYSTATE and friends, and these are _always_ empty for them) the above will begin with "|". There is no need to steal one column from a typeable width from the command line in such a case.

To implement your stated goal (dirty/stash/untracked), you probably want to do this instead...

	local f="$w$i$s$u"
        f="${f:+ $f}$r"

Junio, could you tell us what happened to this thread?

In response to a patch from Roman Fietze to outline a better way to do it. Nothing happened.

Nanako Shiraishi <nanako3@lavabit.com> wrote:

Junio responded with a suggestion on how to improve the patch when GIT_PS1_SHOWDIRTYSTATE was not set, but Roman Fietze didn't send a revised patch, so it got dropped.

Here is the revised patch, Junio, still think its a good idea?

--8<--
From: Roman Fietze <roman.fietze@telemotive.de>
Subject: [PATCH] bash completion: add space between branch name and status flags

Improve the readability of the bash prompt by adding a space between the branch name and the status flags (dirty, stash, untracked).

Signed-off-by: Roman Fietze <roman.fietze@telemotive.de>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 contrib/completion/git-completion.bash |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

"Shawn O. Pearce" <spearce@spearce.org> writes:

Thanks for following up.

As I don't use $[wisu] myself, I don't have a very strong opinion either way, but the user has spent cycles to compute them, so we'd better present them in a way that is easier to read, I guess.

I notice that printf argument look very similar. Maybe we want to do something like

    printf "${1:-" (%s)"}" ...

to avoid duplication?

Improve the readability of the bash prompt by adding a space between the branch name and the status flags (dirty, stash, untracked).

While we are cleaning up this section of code, the two cases for formatting the prompt are identical except for the format string, so make them the same.

Suggested-by: Roman Fietze <roman.fietze@telemotive.de>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
   Junio C Hamano <gitster@pobox.com> wrote:
   > I notice that printf argument look very similar.  Maybe we want to do
   > something like
   > 
   >     printf "${1:-" (%s)"}" ...
   > 
   > to avoid duplication?
   
   Ack.

   Because its rather far from the original poster's patch, I've
   taken blame for it.
   
 contrib/completion/git-completion.bash |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

Hello Shawn,

On Wednesday 30 December 2009 15:57:51 Shawn O. Pearce wrote:

Sorry about that, but our Notes "spam filter" has been eating important mail again.

I'l check the version as proposed by you as soon as I'm back.

Roman