# Name/documentation on git-log --full-diff is insufficient 3 messages from 2009-11-19 to 2009-11-20. Participants: Phil Miller, Miklos Vajna, Tim Henigan. Thread: https://gitlist.dev/t/21677 ## Phil Miller, 2009-11-19 23:26 Subject: Name/documentation on git-log --full-diff is insufficient Message-ID: <81f018ac0911191526o1cfa8e56r79f8db33256a4e9c@mail.gmail.com> URL: https://gitlist.dev/e/81f018ac0911191526o1cfa8e56r79f8db33256a4e9c%40mail.gmail.com ``` I've been trying for a few days to figure out how to see all the files touched in all the commits that changed a particular path. I just discovered that that 'git log --full-diff --stat path' gives me the complete list of files changed in the displayed commits, and not just the files matching path. Reading the documentation, I figured that it either only applied when running 'git log -p' or that it implied the '-p', neither of which was desirable. Thus, I'd suggest a couple potential improvements: 1. Expand the manual text to clarify that --full-diff really means 'tell me about all of the files in the commits that I see' regardless of what information (a list of files, a diffstat, or a full diff) is being printed about those files 2. Add a synonym with a more general name. Something like --all-files would be close to the mark, though there are probably other more suitable names. Phil PS: I sent in a patch for git-cvsserver a week ago, and have seen no response or action on it. Is there something I should have done differently? http://article.gmane.org/gmane.comp.version-control.git/132789 ``` ## Miklos Vajna, 2009-11-20 14:01 Subject: Re: Name/documentation on git-log --full-diff is insufficient Message-ID: <20091120140138.GB23718@genesis.frugalware.org> URL: https://gitlist.dev/e/20091120140138.GB23718%40genesis.frugalware.org In-Reply-To: <81f018ac0911191526o1cfa8e56r79f8db33256a4e9c@mail.gmail.com> ``` On Thu, Nov 19, 2009 at 05:26:33PM -0600, Phil Miller wrote: > PS: I sent in a patch for git-cvsserver a week ago, and have seen no > response or action on it. Is there something I should have done > differently? From MaintNotes: "If you sent a patch that you did not hear from anybody for three days, that is a very good indication that it was dropped on the floor --- please do not hesitate to remind me." ``` ## Tim Henigan, 2009-11-20 14:19 Subject: Re: Name/documentation on git-log --full-diff is insufficient Message-ID: <32c343770911200619i38009e2fy5067a301be3fc313@mail.gmail.com> URL: https://gitlist.dev/e/32c343770911200619i38009e2fy5067a301be3fc313%40mail.gmail.com In-Reply-To: <20091120140138.GB23718@genesis.frugalware.org> ``` On Fri, Nov 20, 2009 at 9:01 AM, Miklos Vajna wrote: > On Thu, Nov 19, 2009 at 05:26:33PM -0600, Phil Miller wrote: >> PS: I sent in a patch for git-cvsserver a week ago, and have seen no >> response or action on it. Is there something I should have done >> differently? > > From MaintNotes: > > "If you sent a patch that you did not hear from anybody for three days, > that is a very good indication that it was dropped on the floor --- > please do not hesitate to remind me." ...also as noted in 'Documentation/SubmittingPatches': - Patches should be placed inline in your email rather than attached. - Patches should be addressed to both: * gitster@pobox.com * git@vger.kernel.org You should also double-check your patch against the rest of the guidelines in 'SubmittingPatches', to be sure it will apply cleanly. ```