# [PATCH] t9700-perl-git.sh: Fix a test failure on Cygwin 5 messages from 2009-11-19 to 2010-01-01. Participants: Ramsay Jones, Nanako Shiraishi, Junio C Hamano. Thread: https://gitlist.dev/t/21669 ## Ramsay Jones, 2009-11-19 18:41 Subject: [PATCH] t9700-perl-git.sh: Fix a test failure on Cygwin Message-ID: <4B059150.5050303@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/4B059150.5050303%40ramsay1.demon.co.uk ``` The t/t9700/test.pl script uses method invocation syntax when using the Cwd module to determine the current working directory. This fails on cygwin, since cygwin perl specifically checks for any arguments to the cwd() function and croak()'s with the message "Usage: Cwd::cwd()". (In perl v5.8.8 distribution, see the file perl-5.8.8/cygwin/cygwin.c lines 139-157) In order to avoid the problem, we replace the method invocation syntax with a simple function call. Signed-off-by: Ramsay Jones --- t/t9700/test.pl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/t/t9700/test.pl b/t/t9700/test.pl index 6c70aec..666722d 100755 --- a/t/t9700/test.pl +++ b/t/t9700/test.pl @@ -13,7 +13,7 @@ use File::Basename; BEGIN { use_ok('Git') } # set up -our $abs_repo_dir = Cwd->cwd; +our $abs_repo_dir = cwd(); ok(our $r = Git->repository(Directory => "."), "open repository"); # config -- 1.6.5 ``` ## Nanako Shiraishi, 2009-12-30 13:40 Subject: Re: [PATCH] t9700-perl-git.sh: Fix a test failure on Cygwin Message-ID: <20091230224023.6117@nanako3.lavabit.com> URL: https://gitlist.dev/e/20091230224023.6117%40nanako3.lavabit.com In-Reply-To: <4B059150.5050303@ramsay1.demon.co.uk> ``` Junio, could you tell us what happened to this thread? ``` ## Junio C Hamano, 2009-12-31 06:49 Subject: Re: [PATCH] t9700-perl-git.sh: Fix a test failure on Cygwin Message-ID: <7vbphfzlgt.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vbphfzlgt.fsf%40alter.siamese.dyndns.org In-Reply-To: <20091230224023.6117@nanako3.lavabit.com> ``` Nanako Shiraishi writes: > Junio, could you tell us what happened to this thread? Hmph, I think we have it as 81f4026 (t9700-perl-git.sh: Fix a test failure on Cygwin, 2009-11-19). ``` ## Nanako Shiraishi, 2010-01-01 00:05 Subject: Re: [PATCH] t9700-perl-git.sh: Fix a test failure on Cygwin Message-ID: <20100101090515.6117@nanako3.lavabit.com> URL: https://gitlist.dev/e/20100101090515.6117%40nanako3.lavabit.com In-Reply-To: <7vbphfzlgt.fsf@alter.siamese.dyndns.org> ``` Quoting Junio C Hamano > Nanako Shiraishi writes: > >> Junio, could you tell us what happened to this thread? > > Hmph, I think we have it as 81f4026 (t9700-perl-git.sh: Fix a test failure > on Cygwin, 2009-11-19). Oh, my mistake. I'm very sorry for wasting your time. -- Nanako Shiraishi http://ivory.ap.teacup.com/nanako3/ ``` ## Junio C Hamano, 2010-01-01 00:07 Subject: Re: [PATCH] t9700-perl-git.sh: Fix a test failure on Cygwin Message-ID: <7v637mr8km.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7v637mr8km.fsf%40alter.siamese.dyndns.org In-Reply-To: <20100101090515.6117@nanako3.lavabit.com> ``` Nanako Shiraishi writes: > Quoting Junio C Hamano > >> Nanako Shiraishi writes: >> >>> Junio, could you tell us what happened to this thread? >> >> Hmph, I think we have it as 81f4026 (t9700-perl-git.sh: Fix a test failure >> on Cygwin, 2009-11-19). > > Oh, my mistake. I'm very sorry for wasting your time. That's Ok; your other reminders were all good ones and greatly appreciated. But let me slow down. I'll reply to the other messages next year ;-). ```