# [PATCH v2 2/2] gitk: add --no-replace-objects option 2 messages from 2009-11-18 to 2009-11-19. Participants: Christian Couder, Paul Mackerras. Thread: https://gitlist.dev/t/21655 ## Christian Couder, 2009-11-18 06:50 Subject: [PATCH v2 2/2] gitk: add --no-replace-objects option Message-ID: <20091118065100.4206.48820.chriscool@tuxfamily.org> URL: https://gitlist.dev/e/20091118065100.4206.48820.chriscool%40tuxfamily.org ``` This option simply sets the GIT_NO_REPLACE_OBJECTS environment variable, and that is enough to make gitk ignore replace refs. The GIT_NO_REPLACE_OBJECTS is set to "1" instead of "" as it is safer on some platforms, thanks to Johannes Sixt and Michael J Gruber. Tested-by: Michael J Gruber Signed-off-by: Christian Couder --- gitk-git/gitk | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/gitk-git/gitk b/gitk-git/gitk index a0214b7..c586b93 100644 --- a/gitk-git/gitk +++ b/gitk-git/gitk @@ -128,7 +128,7 @@ proc unmerged_files {files} { } proc parseviewargs {n arglist} { - global vdatemode vmergeonly vflags vdflags vrevs vfiltered vorigargs + global vdatemode vmergeonly vflags vdflags vrevs vfiltered vorigargs env set vdatemode($n) 0 set vmergeonly($n) 0 @@ -208,6 +208,9 @@ proc parseviewargs {n arglist} { # git rev-parse doesn't understand --merge lappend revargs --gitk-symmetric-diff-marker MERGE_HEAD...HEAD } + "--no-replace-objects" { + set env(GIT_NO_REPLACE_OBJECTS) "1" + } "-*" { # Other flag arguments including - if {[string is digit -strict [string range $arg 1 end]]} { -- 1.6.5.1.gaf97d ``` ## Paul Mackerras, 2009-11-19 09:01 Subject: Re: [PATCH v2 2/2] gitk: add --no-replace-objects option Message-ID: <19205.2405.220888.736317@cargo.ozlabs.ibm.com> URL: https://gitlist.dev/e/19205.2405.220888.736317%40cargo.ozlabs.ibm.com In-Reply-To: <20091118065100.4206.48820.chriscool@tuxfamily.org> ``` Christian Couder writes: > This option simply sets the GIT_NO_REPLACE_OBJECTS environment > variable, and that is enough to make gitk ignore replace refs. For the commit message, could you add a couple of lines telling us what replace refs are and why you might want gitk to ignore them? Paul. ```