threads / patch / 2160

patchcg-fetch: handle tags with funny chars, retrieve missing commits

Subject: [PATCH] cg-fetch: handle tags with funny chars, retrieve missing commits

## tl;dr

2 messages between Oct 20, 2005 and Oct 20, 2005. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Martin Langhoff· Oct 20, 2005, 04:45 UTC · lore
 + handles tags with funny chars a bit better
 + will check tagrefs, trying to ensure it actually has the relevant
   commits. If the commits are missing, it'll go out and fetch them.

This isn't a complete solution for cg-fetch -- git-fetch is actually much smarter now, and cg-fetch should perhaps be a thin wrapper around it, dropping all the duplicate code.

Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
---
 cg-fetch |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

applies-to: 38ed7981343a8e2bb734d64e019186a8a482dbef 21a91d74a6807677f8e59c737fee3692d0f392e8

Show changes to cg-fetch +3 −2
diff --git a/cg-fetch b/cg-fetch
index 7694584..625444c 100755
--- a/cg-fetch
+++ b/cg-fetch
@@ -416,8 +416,9 @@ $get -i -s -u -d "$uri/refs/tags" "$_git
 	cd $_git/refs/tags
 	for tag in *; do
 		[ "$tag" = "*" ] && break
-		tagid=$(cat $tag)
-		GIT_DIR=../.. git-cat-file -t "$tagid" >/dev/null 2>&1 && continue
+		tagid=$(cat "$tag")
+		GIT_DIR=../.. git-cat-file commit `git-rev-parse --verify "$tag"^{commit} 2>/dev/null` 2>/dev/null >> /dev/null && continue
+		GIT_DIR=../.. git-cat-file blob `git-rev-parse --verify "$tag"^{blob} 2>/dev/null` 2>/dev/null >> /dev/null && continue
 		echo -n "Missing object of tag $tag... "
 		if [ "$fetch" != "fetch_rsync" ] && GIT_DIR=../.. $fetch "$tagid" "$uri" 2>/dev/null >&2; then
 			echo "retrieved"
---
0.99.8.GIT
Martin Langhoff· Oct 20, 2005, 05:05 UTC · re: Martin Langhoff · lore

Re: [PATCH] cg-fetch: handle tags with funny chars, retrieve missing commits

Pulled, superceded by new version.
On 10/20/05, Martin Langhoff <martin@catalyst.net.nz> wrote:
Show 9 quoted lines
>  + handles tags with funny chars a bit better
>  + will check tagrefs, trying to ensure it actually has the relevant
>    commits. If the commits are missing, it'll go out and fetch them.
>
> This isn't a complete solution for cg-fetch -- git-fetch is actually
> much smarter now, and cg-fetch should perhaps be a thin wrapper
> around it, dropping all the duplicate code.
>
> Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>

← back to recent threads