Daniel BarkalowIt's okay to use the curl helper without a local repository, so long as you don't use "fetch". There aren't any git programs that would try to use it, and it doesn't make sense to try it (since there's nowhere to write the results), but we may as well be clear.
Signed-off-by: Daniel Barkalow <barkalow@iabervon.org> --- This is the simple change to let remote-curl work without a local repository for git ls-remote; it leave the transport-helper code assuming that all helpers can list without a local repo, which happens to be true of this helper, the only one in current git.
remote-curl.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
Show changes to remote-curl.c +4 −1
diff --git a/remote-curl.c b/remote-curl.c index 2faf1c6..ebdab36 100644 --- a/remote-curl.c +++ b/remote-curl.c @@ -82,9 +82,10 @@ int main(int argc, const char **argv) struct strbuf buf = STRBUF_INIT; const char *url; struct walker *walker = NULL; + int nongit; git_extract_argv0_path(argv[0]); - setup_git_directory(); + setup_git_directory_gently(&nongit); if (argc < 2) { fprintf(stderr, "Remote needed\n"); return 1; @@ -103,6 +104,8 @@ int main(int argc, const char **argv) break; if (!prefixcmp(buf.buf, "fetch ")) { char *obj = buf.buf + strlen("fetch "); + if (nongit) + die("Fetch attempted without a local repo"); if (!walker) walker = get_http_walker(url, remote); walker->get_all = 1;
-- 1.6.5.2.142.g063c5.dirty
