# [PATCH] help -i: properly error out if no info viewer can be found

2 messages from 2009-10-27 to 2009-10-28. Participants: Gerrit Pape, Junio C Hamano.
Thread: https://gitlist.dev/t/21378

## Gerrit Pape, 2009-10-27 13:31

Subject: [PATCH] help -i: properly error out if no info viewer can be found
Message-ID: <20091027133134.28975.qmail@34dfe9cde77152.315fe32.mid.smarden.org>
URL: https://gitlist.dev/e/20091027133134.28975.qmail%4034dfe9cde77152.315fe32.mid.smarden.org

```
With this commit, git help -i <cmd> prints an error message and exits
non-zero instead of being silent and exit code 0.

Reported by Trent W. Buck through
 http://bugs.debian.org/537664

Signed-off-by: Gerrit Pape <pape@smarden.org>
---
 builtin-help.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/builtin-help.c b/builtin-help.c
index e1eba77..e1ade8e 100644
--- a/builtin-help.c
+++ b/builtin-help.c
@@ -372,6 +372,7 @@ static void show_info_page(const char *git_cmd)
 	const char *page = cmd_to_page(git_cmd);
 	setenv("INFOPATH", system_path(GIT_INFO_PATH), 1);
 	execlp("info", "info", "gitman", page, NULL);
+	die("no info viewer handled the request");
 }
 
 static void get_html_page_path(struct strbuf *page_path, const char *page)
-- 
1.6.5.2

```

## Junio C Hamano, 2009-10-28 07:18

Subject: Re: [PATCH] help -i: properly error out if no info viewer can be found
Message-ID: <7vskd4t2aa.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vskd4t2aa.fsf%40alter.siamese.dyndns.org
In-Reply-To: <20091027133134.28975.qmail@34dfe9cde77152.315fe32.mid.smarden.org>

```
Thanks.

```