# [PATCH] Fix cvsimport warning when called without --no-cvs-direct

1 messages from 2005-10-18 to 2005-10-18. Participants: Johannes Schindelin.
Thread: https://gitlist.dev/t/2132

## Johannes Schindelin, 2005-10-18 14:30

Subject: [PATCH] Fix cvsimport warning when called without --no-cvs-direct
Message-ID: <Pine.LNX.4.63.0510181630040.31297@wbgn013.biozentrum.uni-wuerzburg.de>
URL: https://gitlist.dev/e/Pine.LNX.4.63.0510181630040.31297%40wbgn013.biozentrum.uni-wuerzburg.de

```
Perl was warning that $opt_p was undefined in that case.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>

---

 git-cvsimport.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

applies-to: ba55da41e2670b8728cf911ac7424bc1afeb6ce4
8d4a03322860fcc79cd20b76cb91b2f549cf14fd
diff --git a/git-cvsimport.perl b/git-cvsimport.perl
index 0621dc3..bbb83fb 100755
--- a/git-cvsimport.perl
+++ b/git-cvsimport.perl
@@ -487,7 +487,7 @@ unless($pid) {
 	my @opt;
 	@opt = split(/,/,$opt_p) if defined $opt_p;
 	unshift @opt, '-z', $opt_z if defined $opt_z;
-	unless ($opt_p =~ m/--no-cvs-direct/) {
+	unless (defined($opt_p) && $opt_p =~ m/--no-cvs-direct/) {
 		push @opt, '--cvs-direct';
 	}
 	exec("cvsps",@opt,"-u","-A",'--root',$opt_d,$cvs_tree);
---
0.99.8.GIT

```