threads / patch / 21264

patchbash: complete more options for 'git rebase'

Subject: [PATCH] bash: complete more options for 'git rebase'

## tl;dr

3 messages between Oct 17, 2009 and Oct 28, 2009. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Björn Gustavsson· Oct 17, 2009, 09:33 UTC · lore

Complete all long options for 'git rebase' except --no-verify (probably used very seldom) and the long options corresponding to -v, -q, and -f.

Signed-off-by: Björn Gustavsson <bgustavsson@gmail.com>
---
I am primarily interested in having the --whitespace= option completed,
but while at it I have added completion for the other potentially useful
long options.

 contrib/completion/git-completion.bash |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

Show changes to contrib/completion/git-completion.bash +11 −1

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index d3fec32..7c7318c 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1323,8 +1323,18 @@ _git_rebase ()
 	fi
 	__git_complete_strategy && return
 	case "$cur" in
+	--whitespace=*)
+		__gitcomp "$__git_whitespacelist" "" "${cur##--whitespace=}"
+		return
+		;;
 	--*)
-		__gitcomp "--onto --merge --strategy --interactive"
+		__gitcomp "
+			--onto --merge --strategy --interactive
+			--preserve-merges --stat --no-stat
+			--committer-date-is-author-date --ignore-date
+			--ignore-whitespace --whitespace=
+			"
+
 		return
 	esac
 	__gitcomp "$(__git_refs)"

-- 
1.6.5.2.gd6127

Shawn O. Pearce· Oct 28, 2009, 00:32 UTC · re: Björn Gustavsson · lore

Re: [PATCH] bash: complete more options for 'git rebase'

Bj??rn Gustavsson <bgustavsson@gmail.com> wrote:

Show 5 quoted lines

> Complete all long options for 'git rebase' except --no-verify
> (probably used very seldom) and the long options corresponding
> to -v, -q, and -f.
> 
> Signed-off-by: Bj??rn Gustavsson <bgustavsson@gmail.com>

Acked-by: Shawn O. Pearce <spearce@spearce.org>

> I am primarily interested in having the --whitespace= option completed,
> but while at it I have added completion for the other potentially useful
> long options.

Indeed, this would be nice.  :-)

-- 
Shawn.

Junio C Hamano· Oct 28, 2009, 07:19 UTC · re: Shawn O. Pearce · lore

Re: [PATCH] bash: complete more options for 'git rebase'

"Shawn O. Pearce" <spearce@spearce.org> writes:

Show 12 quoted lines

> Bj??rn Gustavsson <bgustavsson@gmail.com> wrote:
>> Complete all long options for 'git rebase' except --no-verify
>> (probably used very seldom) and the long options corresponding
>> to -v, -q, and -f.
>> 
>> Signed-off-by: Bj�rn Gustavsson <bgustavsson@gmail.com>
>
> Acked-by: Shawn O. Pearce <spearce@spearce.org>
>
>> I am primarily interested in having the --whitespace= option completed,
>> but while at it I have added completion for the other potentially useful
>> long options.

Thanks.