# [PATCH] generators/vcproj.pm: remove UNICODE from build 2 messages from 2009-09-28 to 2009-09-28. Participants: Michael Wookey, Marius Storm-Olsen. Thread: https://gitlist.dev/t/21079 ## Michael Wookey, 2009-09-28 10:46 Subject: [PATCH] generators/vcproj.pm: remove UNICODE from build Message-ID: URL: https://gitlist.dev/e/d2e97e800909280346s12c205f2gf95ff4c135d4625c%40mail.gmail.com ``` Defining UNICODE for MSVC IDE builds results in certain Win32 WIDE API's receiving ANSI strings. The result of which is an invalid use of the API and will end in either data corruption or an application crash. Prevent the use of WIDE API's when building with the MSVC IDE for compatibility with msysGit. Signed-off-by: Michael Wookey --- contrib/buildsystems/Generators/Vcproj.pm | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/contrib/buildsystems/Generators/Vcproj.pm b/contrib/buildsystems/Generators/Vcproj.pm index 00ec0c1..a215911 100644 --- a/contrib/buildsystems/Generators/Vcproj.pm +++ b/contrib/buildsystems/Generators/Vcproj.pm @@ -173,7 +173,7 @@ sub createLibProject { Optimization="0" InlineFunctionExpansion="1" AdditionalIncludeDirectories="$includes" - PreprocessorDefinitions="UNICODE,WIN32,_DEBUG,$defines" + PreprocessorDefinitions="WIN32,_DEBUG,$defines" MinimalRebuild="true" RuntimeLibrary="1" UsePrecompiledHeader="0" @@ -239,7 +239,7 @@ sub createLibProject { InlineFunctionExpansion="1" EnableIntrinsicFunctions="true" AdditionalIncludeDirectories="$includes" - PreprocessorDefinitions="UNICODE,WIN32,NDEBUG,$defines" + PreprocessorDefinitions="WIN32,NDEBUG,$defines" RuntimeLibrary="0" EnableFunctionLevelLinking="true" UsePrecompiledHeader="0" @@ -395,7 +395,7 @@ sub createAppProject { Optimization="0" InlineFunctionExpansion="1" AdditionalIncludeDirectories="$includes" - PreprocessorDefinitions="UNICODE,WIN32,_DEBUG,$defines" + PreprocessorDefinitions="WIN32,_DEBUG,$defines" MinimalRebuild="true" RuntimeLibrary="1" UsePrecompiledHeader="0" @@ -466,7 +466,7 @@ sub createAppProject { InlineFunctionExpansion="1" EnableIntrinsicFunctions="true" AdditionalIncludeDirectories="$includes" - PreprocessorDefinitions="UNICODE,WIN32,NDEBUG,$defines" + PreprocessorDefinitions="WIN32,NDEBUG,$defines" RuntimeLibrary="0" EnableFunctionLevelLinking="true" UsePrecompiledHeader="0" -- 1.6.5.rc2 ``` ## Marius Storm-Olsen, 2009-09-28 12:39 Subject: Re: [PATCH] generators/vcproj.pm: remove UNICODE from build Message-ID: <4AC0AE7C.3080308@gmail.com> URL: https://gitlist.dev/e/4AC0AE7C.3080308%40gmail.com In-Reply-To: ``` Michael Wookey said the following on 28.09.2009 12:46: > Defining UNICODE for MSVC IDE builds results in certain Win32 WIDE API's > receiving ANSI strings. The result of which is an invalid use of the API > and will end in either data corruption or an application crash. > > Prevent the use of WIDE API's when building with the MSVC IDE for > compatibility with msysGit. > > Signed-off-by: Michael Wookey > --- After manually editing the patch until it applied (some headers which gt-am didn't like): Acked-by: Marius Storm-Olsen -- .marius ```