threads / patch / 21063

patchgit branch -D: give a better error message when lockfile creation fails

Subject: [PATCH] git branch -D: give a better error message when lockfile creation fails

## tl;dr

One message between Sep 25, 2009 and Sep 25, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Miklos Vajna· Sep 25, 2009, 23:53 UTC · lore

Previously the old error message just told the user that it was not possible to delete the ref from the packed-refs file. Give instructions on how to resolve the problem.

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
 refs.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
Show changes to refs.c +3 −1
diff --git a/refs.c b/refs.c
index 24865cf..221d49c 100644
--- a/refs.c
+++ b/refs.c
@@ -972,8 +972,10 @@ static int repack_without_ref(const char *refname)
 	if (!found)
 		return 0;
 	fd = hold_lock_file_for_update(&packlock, git_path("packed-refs"), 0);
-	if (fd < 0)
+	if (fd < 0) {
+		unable_to_lock_index_die(git_path("packed-refs"), errno);
 		return error("cannot delete '%s' from packed refs", refname);
+	}
 
 	for (list = packed_ref_list; list; list = list->next) {
 		char line[PATH_MAX + 100];
-- 
1.6.5.rc1.44.ga1675.dirty

← back to recent threads