# [PATCH] Revert "Also use 'track_object_refs = 0' in update-server-info." 1 messages from 2005-10-13 to 2005-10-13. Participants: Junio C Hamano. Thread: https://gitlist.dev/t/2092 ## Junio C Hamano, 2005-10-13 17:20 Subject: [PATCH] Revert "Also use 'track_object_refs = 0' in update-server-info." Message-ID: <7v1x2p49lp.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7v1x2p49lp.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <20051013161010.GC12092@master.mivlgu.local> ``` Sergey spotted a grave bug, already in "master", which shows my lack of testing. I just pushed out his fix, which is to revert d119e3de13ea1493107bd57381d0ce9c9dd90976. It should propagate to the mirrors soon. If you used git-update-server-info with the bug on your repository, you will find a huge objects/info/packs file. Usually it should list just a handful edge tags and commits, but with the bug it practically lists everything. After rebuilding the fixed git-update-server-info, please run 'git-update-server-info -f' there to fix this problem. Sorry for the stupid bug, and many thanks to Sergey. ------------ This reverts d119e3de13ea1493107bd57381d0ce9c9dd90976 commit. Object references are used in server-info.c:find_pack_info_one() to find out which objects in the pack are heads, therefore tracking of references cannot be disabled. Signed-off-by: Sergey Vlasov Signed-off-by: Junio C Hamano --- Looks like this bug has caused objects/info/packs in the linux-2.4 repository to grow huge and hit the limit, which I then needed to remove in the previous patch. update-server-info.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) applies-to: 1970e5869a42fd4095917d861654dc84d60f02b7 985738719bfb5284911871f15180a2aee6512d53 diff --git a/update-server-info.c b/update-server-info.c index b708563..e824f62 100644 --- a/update-server-info.c +++ b/update-server-info.c @@ -1,5 +1,4 @@ #include "cache.h" -#include "object.h" static const char update_server_info_usage[] = "git-update-server-info [--force]"; @@ -8,8 +7,6 @@ int main(int ac, char **av) { int i; int force = 0; - track_object_refs = 0; - for (i = 1; i < ac; i++) { if (av[i][0] == '-') { if (!strcmp("--force", av[i]) || --- 0.99.8.GIT ```