# [PATCH] pack-objects: free preferred base memory after usage

1 messages from 2009-09-04 to 2009-09-04. Participants: Nicolas Pitre.
Thread: https://gitlist.dev/t/20837

## Nicolas Pitre, 2009-09-04 01:54

Subject: [PATCH] pack-objects: free preferred base memory after usage
Message-ID: <alpine.LFD.2.00.0909032139010.6044@xanadu.home>
URL: https://gitlist.dev/e/alpine.LFD.2.00.0909032139010.6044%40xanadu.home

```
When adding objects for preferred delta base, the content from tree 
objects leading to given paths is kept in a cache. This has the 
potential to grow significantly, especially with large directories as 
the whole tree object content is loaded in memory, even if in practice 
the number of those objects is limited to the 256 cache entries plus the 
$window root tree objects.  Still, that can't hurt freeing that up after 
object enumeration is done, and before more memory is needed for delta 
search.

Signed-off-by: Nicolas Pitre <nico@cam.org>

diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c
index 1ff2ce6..ae7ce0f 100644
--- a/builtin-pack-objects.c
+++ b/builtin-pack-objects.c
@@ -1008,6 +1008,33 @@ static void add_preferred_base(unsigned char *sha1)
 	it->pcache.tree_size = size;
 }
 
+static void cleanup_preferred_base(void)
+{
+	struct pbase_tree *it;
+	unsigned i;
+	
+	it = pbase_tree;
+	pbase_tree = NULL;
+	while (it) {
+		struct pbase_tree *this = it;
+		it = this->next;
+		free(this->pcache.tree_data);
+		free(this);
+	}
+	
+	for (i = 0; i < ARRAY_SIZE(pbase_tree_cache); i++) {
+		if (!pbase_tree_cache[i])
+			continue;
+		free(pbase_tree_cache[i]->tree_data);
+		free(pbase_tree_cache[i]);
+		pbase_tree_cache[i] = NULL;
+	}
+
+	free(done_pbase_paths);
+	done_pbase_paths = NULL;
+	done_pbase_paths_num = done_pbase_paths_alloc = 0;
+}
+
 static void check_object(struct object_entry *entry)
 {
 	if (entry->in_pack) {
@@ -2312,6 +2339,7 @@ int cmd_pack_objects(int argc, const char **argv, const char *prefix)
 		rp_av[rp_ac] = NULL;
 		get_object_list(rp_ac, rp_av);
 	}
+	cleanup_preferred_base();
 	if (include_tag && nr_result)
 		for_each_ref(add_ref_tag, NULL);
 	stop_progress(&progress_state);

```