# [JGIT PATCH] fixed error in whitespace handling of RefDatabase#readLine 2 messages from 2009-09-01 to 2009-09-01. Participants: Mark Struberg, Shawn O. Pearce. Thread: https://gitlist.dev/t/20815 ## Mark Struberg, 2009-09-01 21:18 Subject: [JGIT PATCH] fixed error in whitespace handling of RefDatabase#readLine Message-ID: <196796.47610.qm@web27808.mail.ukl.yahoo.com> URL: https://gitlist.dev/e/196796.47610.qm%40web27808.mail.ukl.yahoo.com ``` jgit fails with "cannot checkout; no HEAD advertised by remote" in guessHEAD on some repositories. JGIT used to work on my test repo for the maven-scm-providers-git until a few weeks. I tracked it down with git bisect and found commit 72b1f0d334729a49cc52e4762093148be62bea39 to be the bad one. I glimpsed at the code and it appears that the new code in RefDatabase#readLine is not Windows CR+LF aware. (This hits me although I use Linux because our SVN at apache.org seems to have it stored with CR+LF.) Fixed by subsequently removing all Character.isWhitespaceChar() from the end of the buffer Signed-off-by: Mark Struberg --- .../src/org/spearce/jgit/lib/RefDatabase.java | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/RefDatabase.java b/org.spearce.jgit/src/org/spearce/jgit/lib/RefDatabase.java index ba4b654..477dc62 100644 --- a/org.spearce.jgit/src/org/spearce/jgit/lib/RefDatabase.java +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/RefDatabase.java @@ -500,8 +500,12 @@ private static String readLine(final File file) int n = buf.length; if (n == 0) return null; - if (buf[n - 1] == '\n') + + // remove trailing whitespaces + while (n > 0 && Character.isWhitespace(buf[n - 1])) { n--; + } + return RawParseUtils.decode(buf, 0, n); } -- 1.6.2.5 ``` ## Shawn O. Pearce, 2009-09-01 23:15 Subject: Re: [JGIT PATCH] fixed error in whitespace handling of RefDatabase#readLine Message-ID: <20090901231524.GA1033@spearce.org> URL: https://gitlist.dev/e/20090901231524.GA1033%40spearce.org In-Reply-To: <196796.47610.qm@web27808.mail.ukl.yahoo.com> ``` Mark Struberg wrote: > jgit fails with "cannot checkout; no HEAD advertised by remote" > in guessHEAD on some repositories. ... > @@ -500,8 +500,12 @@ private static String readLine(final File file) > int n = buf.length; > if (n == 0) Whitespace damage here, the patch won't apply as-is. Also, please line wrap your commit message. -- Shawn. ```