The old behavior just said that it failed. Now it includes the error information, which makes it much easier to debug.
There is a risk that some failure paths could result in misleading error messages that actually make debugging more difficult.
Signed-off-by: David Reiss <dreiss@facebook.com> --- Sorry I missed that.
builtin-commit.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
Show changes to builtin-commit.c +3 −3
diff --git a/builtin-commit.c b/builtin-commit.c index 4bcce06..7feb598 100644 --- a/builtin-commit.c +++ b/builtin-commit.c @@ -256,7 +256,7 @@ static char *prepare_index(int argc, const char **argv, const char *prefix) refresh_cache(REFRESH_QUIET); if (write_cache(fd, active_cache, active_nr) || close_lock_file(&index_lock)) - die("unable to write new_index file"); + die_errno("unable to write new_index file"); commit_style = COMMIT_NORMAL; return index_lock.filename; } @@ -275,7 +275,7 @@ static char *prepare_index(int argc, const char **argv, const char *prefix) refresh_cache(REFRESH_QUIET); if (write_cache(fd, active_cache, active_nr) || commit_locked_index(&index_lock)) - die("unable to write new_index file"); + die_errno("unable to write new_index file"); commit_style = COMMIT_AS_IS; return get_index_file(); } @@ -318,7 +318,7 @@ static char *prepare_index(int argc, const char **argv, const char *prefix) refresh_cache(REFRESH_QUIET); if (write_cache(fd, active_cache, active_nr) || close_lock_file(&index_lock)) - die("unable to write new_index file"); + die_errno("unable to write new_index file"); fd = hold_lock_file_for_update(&false_lock, git_path("next-index-%"PRIuMAX,
-- 1.6.0.4