threads / patch / 2081

patchcogito: use locale date_fmt in obtaining default date format

Subject: [PATCH] cogito: use locale date_fmt in obtaining default date format

## tl;dr

2 messages between Oct 12, 2005 and Oct 12, 2005. Diffs are folded; open one to read it.

replies: 1people: 1as markdown or json

Junichi Uekawa· Oct 12, 2005, 14:02 UTC · lore

Obtain the default date format information from the locale database if it's available. Currently, the default date is in a fixed format that is mostly US-centric; which results in a very weird-looking Japanese date.

Signed-off-by: Junichi Uekawa <dancer@debian.org>

---

 cg-Xlib |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

Show changes to cg-Xlib +3 −1

diff --git a/cg-Xlib b/cg-Xlib
index 0ed275f..d6d0cc1 100755
--- a/cg-Xlib
+++ b/cg-Xlib
@@ -210,7 +210,9 @@ showdate()
 	# bash doesn't like leading zeros
 	[ "${tzhours:1:1}" = 0 ] && tzhours=${2:0:1}${2:2:1}
 	secs=$(($secs + $tzhours * 3600 + $tzmins * 60))
-	[ "$format" ] || format="+%a, %d %b %Y %H:%M:%S $2"
+	[ "$format" ] || \
+		format="+$(locale date_fmt)" || \
+		format="+%a, %d %b %Y %H:%M:%S $2"
 	if [ "$has_gnudate" ]; then
 		LANG=C $has_gnudate -ud "1970-01-01 UTC + $secs sec" "$format"
 	else

Junichi Uekawa· Oct 12, 2005, 15:26 UTC · re: Junichi Uekawa · lore

Re: [PATCH] cogito: use locale date_fmt in obtaining default date format

Hi,

>  	if [ "$has_gnudate" ]; then
>  		LANG=C $has_gnudate -ud "1970-01-01 UTC + $secs sec" "$format"
>  	else

Hmm... I just noticed that you're setting LANG=C here; which is not enough since LC_ALL will override the value.

I'm not quite sure of the original intention; I've checked the users

cg-log:
	For local display; it should be okay to show the date in 
	localized format.

cg-mkpatch:
	It might be intrusive to have a localized date in a patch;
	so having a localized output of showdate is mostly undesirable,
	but it will depend on the project you work on.
	(The user can always unset locale)

regards,
	junichi