# Generating patches/Cherry Picking for a large number of commits 7 messages from 2009-08-28 to 2009-08-28. Participants: Alydis, Jeff King, Jakub Narebski, Junio C Hamano. Thread: https://gitlist.dev/t/20777 ## Alydis, 2009-08-28 19:26 Subject: Generating patches/Cherry Picking for a large number of commits Message-ID: URL: https://gitlist.dev/e/ae09c2a40908281226r744141bm3a5bf4161ddab3e7%40mail.gmail.com ``` Hi, Newly converted git user here.  I've stopped working with Subversion ever since working with the Linux kernel has introduced me to git, and never looked back! I am currently working on a project in which I'm trying to backport the powerpc boot-wrapper and device tree handling from Linux 2.6.30 into Linux 2.6.21.  We have some third party vendor code that is not ready for the (new) completely fair scheduler just yet.  Yet, our BSP relies on cuImage and the DTS files. The approach I'm taking is to try to cherry-pick any commits between v2.6.21 and v2.6.30 on the Linux kernel git repository that touch any file in the arch/powerpc/boot directory into a v2.6.21 branch (and pray that the conflicts are manageable). I've tried something along these lines: git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6 cd linux-2.6 git checkout -b mybranch v2.6.21 git format-patch -o patches v2.6.21..v2.6.30 arch/powerpc/boot git am -3 patches/* But, to my dismay, format-patch here tears apart the commits and applies ONLY the hunks that apply to the arch/powerpc/boot directory. What I'd much rather do is obtain a list of commits that apply to arch/powerpc/boot; but, then apply the entire patch. I'm a bit lost at how to proceed at this point?  Do I need to write my own script that uses git-log to grab the commit hashes that I want, then call format-patch (or diff/apply/etc) individually on each of them?  I realize I'll have to handle patch numbering myself, if I were to do that (luckily, I believe format-patch allows you to specify the starting number).  I also know at some point, I'll have to drill down into individual commits and do some more detailed cherry picking to form the desired patch series.  This script seems like a good deal of work for me... so before I go off and start it, I was wondering if the git gurus have any clever solutions for me? Thanks, Tommy Wang ``` ## Jeff King, 2009-08-28 19:45 Subject: Re: Generating patches/Cherry Picking for a large number of commits Message-ID: <20090828194556.GA13302@coredump.intra.peff.net> URL: https://gitlist.dev/e/20090828194556.GA13302%40coredump.intra.peff.net In-Reply-To: ``` On Fri, Aug 28, 2009 at 02:26:43PM -0500, Alydis wrote: > I've tried something along these lines: > > git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6 > cd linux-2.6 > git checkout -b mybranch v2.6.21 > git format-patch -o patches v2.6.21..v2.6.30 arch/powerpc/boot > git am -3 patches/* > > But, to my dismay, format-patch here tears apart the commits and > applies ONLY the hunks that apply to the arch/powerpc/boot directory. > What I'd much rather do is obtain a list of commits that apply to > arch/powerpc/boot; but, then apply the entire patch. By default, format-patch (and log, gitk, etc) when given a path limiter will also limit the diff shown. You can override it with --full-diff. -Peff ``` ## Alydis, 2009-08-28 19:50 Subject: Re: Generating patches/Cherry Picking for a large number of commits Message-ID: URL: https://gitlist.dev/e/ae09c2a40908281250r42275a3o96825b89e725bace%40mail.gmail.com In-Reply-To: <20090828194556.GA13302@coredump.intra.peff.net> ``` Ack! Embarrassing RTFM. While I have your attention, however, I noticed that git am will apply the list patches generated by format-patch. The documentation said something about mbox/maildir directories, which I actually am not that familiar with. Is it safe to say that git am will read the path and apply patches in numerical order? Does it allow skipping? Thanks again, Tommy Wang On Fri, Aug 28, 2009 at 2:45 PM, Jeff King wrote: > On Fri, Aug 28, 2009 at 02:26:43PM -0500, Alydis wrote: > >> I've tried something along these lines: >> >> git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6 >> cd linux-2.6 >> git checkout -b mybranch v2.6.21 >> git format-patch -o patches v2.6.21..v2.6.30 arch/powerpc/boot >> git am -3 patches/* >> >> But, to my dismay, format-patch here tears apart the commits and >> applies ONLY the hunks that apply to the arch/powerpc/boot directory. >> What I'd much rather do is obtain a list of commits that apply to >> arch/powerpc/boot; but, then apply the entire patch. > > By default, format-patch (and log, gitk, etc) when given a path limiter > will also limit the diff shown. You can override it with --full-diff. > > -Peff > ``` ## Jakub Narebski, 2009-08-28 20:34 Subject: Re: Generating patches/Cherry Picking for a large number of commits Message-ID: URL: https://gitlist.dev/e/m3k50nllt6.fsf%40localhost.localdomain In-Reply-To: ``` [Alydis, please do not toppost] Alydis writes: > On Fri, Aug 28, 2009 at 2:45 PM, Jeff King wrote: >> On Fri, Aug 28, 2009 at 02:26:43PM -0500, Alydis wrote: >> >>> I've tried something along these lines: >>> [...] >>> git format-patch -o patches v2.6.21..v2.6.30 arch/powerpc/boot >>> git am -3 patches/* >>> >>> But, to my dismay, format-patch here tears apart the commits and >>> applies ONLY the hunks that apply to the arch/powerpc/boot directory. >>> What I'd much rather do is obtain a list of commits that apply to >>> arch/powerpc/boot; but, then apply the entire patch. >> >> By default, format-patch (and log, gitk, etc) when given a path limiter >> will also limit the diff shown. You can override it with --full-diff. > > Ack! Embarrassing RTFM. > > While I have your attention, however, I noticed that git am > will apply the list patches generated by format-patch. The > documentation said something about mbox/maildir directories, which I > actually am not that familiar with. Is it safe to say that git am > will read the path and apply patches in numerical order? git-format-patch | git-am pipeline has to work correctly, as it originally was the way (modulo extra options) git-rebase was implemented. So yes, "git am " should understand and apply in correct order result of "git format-patch -o ". > Does it allow skipping? There is "git am -i". -- Jakub Narebski Poland ShadeHawk on #git ``` ## Jeff King, 2009-08-28 21:54 Subject: Re: Generating patches/Cherry Picking for a large number of commits Message-ID: <20090828215420.GA18336@coredump.intra.peff.net> URL: https://gitlist.dev/e/20090828215420.GA18336%40coredump.intra.peff.net In-Reply-To: ``` On Fri, Aug 28, 2009 at 02:50:53PM -0500, Alydis wrote: > While I have your attention, however, I noticed that git am > will apply the list patches generated by format-patch. The > documentation said something about mbox/maildir directories, which I > actually am not that familiar with. Is it safe to say that git am > will read the path and apply patches in numerical order? Does > it allow skipping? It will apply the patches in the order given on the command line. When your shell expands the "patches/*" glob, it will do so in lexically sorted order. Meaning "0001" comes before "0002", etc, which is the reason that format-patch zero-pads the filenames. You can edit or delete the patches in your patch directory before applying, and they should apply the same (unless you create a patch that cannot actually be applied). -Peff ``` ## Junio C Hamano, 2009-08-28 22:31 Subject: Re: Generating patches/Cherry Picking for a large number of commits Message-ID: <7vmy5jh8oa.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vmy5jh8oa.fsf%40alter.siamese.dyndns.org In-Reply-To: ``` Alydis writes: > Ack! Embarrassing RTFM. > > While I have your attention, however, I noticed that git am > will apply the list patches generated by format-patch. The > documentation said something about mbox/maildir directories, which I > actually am not that familiar with. Is it safe to say that git am > will read the path and apply patches in numerical order? Does > it allow skipping? If you say "git am /*", like you have in your original message shown *below* (sheesh, why am I responding to somebody who top-posts?), you let your shell perform a numerical sort, so you would be Ok. >>> git format-patch -o patches v2.6.21..v2.6.30 arch/powerpc/boot >>> git am -3 patches/* I do not think the above format-patch, even with --full-diff, is necessarily a good idea nor would work in general. Often, when a series is concocted, you would see this pattern: * Early parts of the patch series to lay groundwork by introducing non platform specific infrastructure; and then * Later parts of the series utilizes the infrastructure to implement the feature for particular platforms. Obviously you are interested only for powerpc parts in the latter category and would want to omit anything irrelevant to powerpc. But you do want to include all of the former class, even if they do not touch anything inside the powerpc area. ``` ## Junio C Hamano, 2009-08-28 22:35 Subject: Re: Generating patches/Cherry Picking for a large number of commits Message-ID: <7v1vmvh8hs.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7v1vmvh8hs.fsf%40alter.siamese.dyndns.org In-Reply-To: ``` Jakub Narebski writes: > git-format-patch | git-am pipeline has to work correctly, as it > originally was the way (modulo extra options) git-rebase was > implemented. So yes, "git am " should understand and apply in > correct order result of "git format-patch -o ". You are not making any sense. rebase is done using --stdout and does not rely on the intermediate files nor ordering of their names. ```