threads / discuss / 2077

Make git config variable names case-insensitive

Subject: Make git config variable names case-insensitive

## tl;dr

One message between Oct 12, 2005 and Oct 12, 2005.

replies: 0people: 1as markdown or json

Linus Torvalds· Oct 12, 2005, 01:09 UTC · lore

They always were meant to be case-insensitive, but I had missed one "tolower()", making that not true.

The actual _values_ aren't case-insensitive, of course, although some uses of them may be (ie boolean parsing uses "strcasecmp()" to match against the strings "true" and "false").

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

This should independent of the other patch - it should apply whether you've taken the [user]name/email config thing or not. But it was generated on top of that change.

diff --git a/config.c b/config.c
index cf80358..9b7c6f2 100644
--- a/config.c
+++ b/config.c
@@ -168,7 +168,7 @@ static int git_parse_file(config_fn_t fn
 		}
 		if (!isalpha(c))
 			break;
-		var[baselen] = c;
+		var[baselen] = tolower(c);
 		if (get_value(fn, var, baselen+1) < 0)
 			break;
 	}

← back to recent threads