threads / discuss / 20754

vc in emacs problem with git

Subject: vc in emacs problem with git

## tl;dr

6 messages between Aug 27, 2009 and Aug 30, 2009.

replies: 5people: 3as markdown or json

Rustom Mody· Aug 27, 2009, 15:28 UTC · lore

This is emacs 23 using the new 'updated-for-modern-dvcs' vc I see a mode line saying (note the colon) Git:master

In the info on vc (Version control and the mode line) the emacs manual says:

  The character between the back-end name and the revision ID
indicates the version control status of the file.  `-' means that the
work file is not locked (if locking is in use), or not modified (if
locking is not in use).  `:' indicates that the file is locked, or that
it is modified.

However at the shell a git status says # On branch master nothing to commit (working directory clean)

If I close and reopen the file the colon becomes a - But I get a message:

`working-revision' not found: using the old `workfile-version' instead.

Rustom Mody· Aug 27, 2009, 16:14 UTC · re: Rustom Mody · lore

Re: vc in emacs problem with git

Just updating my own question: when I do a C-x v v (vc-next-action) which is supposed to be the most basic operation for checking in a file I get

 Wrong type argument: stringp, nil

So vc can be assumed to be a broken I guess?

On Thu, Aug 27, 2009 at 8:58 PM, Rustom Mody<rustompmody@gmail.com> wrote:

Show 21 quoted lines

> This is emacs 23 using the new 'updated-for-modern-dvcs' vc
> I see a mode line saying (note the colon)
> Git:master
>
> In the info on vc (Version control and the mode line) the emacs manual says:
>
>   The character between the back-end name and the revision ID
> indicates the version control status of the file.  `-' means that the
> work file is not locked (if locking is in use), or not modified (if
> locking is not in use).  `:' indicates that the file is locked, or that
> it is modified.
>
> However at the shell a git status says
> # On branch master
> nothing to commit (working directory clean)
>
> If I close and reopen the file the colon becomes a -
> But I get a message:
>
> `working-revision' not found: using the old `workfile-version' instead.
>

Tassilo Horn· Aug 27, 2009, 17:45 UTC · re: Rustom Mody · lore

Re: vc in emacs problem with git

Rustom Mody <rustompmody@gmail.com> writes:

Hi Rustom,

Show 7 quoted lines

> Just updating my own question:
> when I do a C-x v v (vc-next-action)
> which is supposed to be the most basic operation for checking in a file I get
>
>  Wrong type argument: stringp, nil
>
> So vc can be assumed to be a broken I guess?

Hm, please do `M-x toggle-debug-on-error', reproduce the error and poste the backtrace.

Bye, Tassilo

Rustom Mody· Aug 29, 2009, 14:37 UTC · re: Rustom Mody · lore

Re: vc in emacs problem with git

On Thu, Aug 27, 2009 at 9:44 PM, Rustom Mody<rustompmody@gmail.com> wrote:

Show 7 quoted lines

> Just updating my own question:
> when I do a C-x v v (vc-next-action)
> which is supposed to be the most basic operation for checking in a file I get
>
>  Wrong type argument: stringp, nil
>
> So vc can be assumed to be a broken I guess?

Answering my own question:
Short answer: vc-git.el from git breaks vc in emacs
Long answer: see emacs mailing list discussion
 http://groups.google.com/group/gnu.emacs.help/browse_thread/thread/657d9c58baed7b0f#

Junio C Hamano· Aug 29, 2009, 18:41 UTC · re: Rustom Mody · lore

Re: vc in emacs problem with git

Rustom Mody <rustompmody@gmail.com> writes:

Show 7 quoted lines

> Just updating my own question:
> when I do a C-x v v (vc-next-action)
> which is supposed to be the most basic operation for checking in a file I get
>
>  Wrong type argument: stringp, nil
>
> So vc can be assumed to be a broken I guess?

Have you checked contrib/emacs/README?

Rustom Mody· Aug 30, 2009, 08:54 UTC · re: Junio C Hamano · lore

Re: vc in emacs problem with git

On Sun, Aug 30, 2009 at 12:11 AM, Junio C Hamano<gitster@pobox.com> wrote:

Show 12 quoted lines

> Rustom Mody <rustompmody@gmail.com> writes:
>
>> Just updating my own question:
>> when I do a C-x v v (vc-next-action)
>> which is supposed to be the most basic operation for checking in a file I get
>>
>>  Wrong type argument: stringp, nil
>>
>> So vc can be assumed to be a broken I guess?
>
> Have you checked contrib/emacs/README?
> --

Sorry Junio I should have checked.

Actually I had earlier checked. Then I tried many emacs-git options, none of which worked. Then I upgraded my emacs to 23 in which the vc is upgraded for dvses like git. Time passed and I forgot what I had found, made worse by the fact that sometimes I'm on windows and sometimes on linux and the 'working' status of different things is quite different.

However the point is that I was not loading the older vc-git.el at all. emacs was getting the wrong one. It may be better if vc were hardened so that it gets its own vc-*.els in preference to random stuff lying on the load-path.