# [PATCH v2] Fix symlink __stdcall problem at MSVC 3 messages from 2009-08-20 to 2009-08-21. Participants: Frank Li. Thread: https://gitlist.dev/t/20674 ## Frank Li, 2009-08-20 14:21 Subject: [PATCH v2] Fix symlink __stdcall problem at MSVC Message-ID: <1250778072-4324-1-git-send-email-lznuaa@gmail.com> URL: https://gitlist.dev/e/1250778072-4324-1-git-send-email-lznuaa%40gmail.com ``` MSVC requires that __stdcall be between return value and function name. Further, all Win32 API definitions look like this: TYPE WINAPI function_name... Signed-off-by: Frank Li --- compat/mingw.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/compat/mingw.c b/compat/mingw.c index fd642e4..4256243 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -1421,7 +1421,7 @@ int link(const char *oldpath, const char *newpath) int symlink(const char *oldpath, const char *newpath) { - typedef BOOL WINAPI (*symlink_fn)(const char*, const char*, DWORD); + typedef BOOL (WINAPI *symlink_fn)(const char*, const char*, DWORD); static symlink_fn create_symbolic_link = NULL; if (!create_symbolic_link) { create_symbolic_link = (symlink_fn) GetProcAddress( -- 1.6.4.msysgit.0 ``` ## Frank Li, 2009-08-21 02:42 Subject: Re: [PATCH v2] Fix symlink __stdcall problem at MSVC Message-ID: <1976ea660908201942r7ba14d1cnbb516f9f2c31f8bb@mail.gmail.com> URL: https://gitlist.dev/e/1976ea660908201942r7ba14d1cnbb516f9f2c31f8bb%40mail.gmail.com In-Reply-To: <1250778072-4324-1-git-send-email-lznuaa@gmail.com> ``` > > int symlink(const char *oldpath, const char *newpath) > { > - typedef BOOL WINAPI (*symlink_fn)(const char*, const char*, DWORD); > + typedef BOOL (WINAPI *symlink_fn)(const char*, const char*, DWORD); > static symlink_fn create_symbolic_link = NULL; > if (!create_symbolic_link) { > create_symbolic_link = (symlink_fn) GetProcAddress( > -- > 1.6.4.msysgit.0 > This is new patch for latest devel branch mingw.c. ``` ## Frank Li, 2009-08-21 02:57 Subject: Re: [PATCH v2] Fix symlink __stdcall problem at MSVC Message-ID: <1976ea660908201957l76ebf555wbbbda0dbfb8cbdd7@mail.gmail.com> URL: https://gitlist.dev/e/1976ea660908201957l76ebf555wbbbda0dbfb8cbdd7%40mail.gmail.com In-Reply-To: <1250778072-4324-1-git-send-email-lznuaa@gmail.com> ``` > > int symlink(const char *oldpath, const char *newpath) > { > - typedef BOOL WINAPI (*symlink_fn)(const char*, const char*, DWORD); > + typedef BOOL (WINAPI *symlink_fn)(const char*, const char*, DWORD); > static symlink_fn create_symbolic_link = NULL; > if (!create_symbolic_link) { > create_symbolic_link = (symlink_fn) GetProcAddress( > -- > 1.6.4.msysgit.0 > This is new patch for latest devel branch mingw.c. ```