threads / patch / 20627

v4, 6 partsrevision caching mechanism to significantly speed up packing/walking (last version)

Subject: [PATCH 0/6 (v4)] revision caching mechanism to significantly speed up packing/walking (last version)

## tl;dr

2 messages between Aug 17, 2009 and Aug 18, 2009. Diffs are folded; open one to read it.

replies: 1people: 1as markdown or json

Nick Edelen· Aug 17, 2009, 12:31 UTC · lore
SUGGESTED FOR 'PU':

Traversing objects is currently very costly, as every commit and tree must be loaded and parsed. Much time and energy could be saved by caching metadata and topological info in an efficient, easily accessible manner. Furthermore, this could improve git's interfacing potential, by providing a condensed summary of a repository's commit tree.

This is a series to implement such a revision caching mechanism, aptly named 
rev-cache.  The series will provide:
 - a core API to manipulate and traverse caches
 - an integration into the internal revision walker
 - a porcelain front-end providing access to users and (shell) applications
 - a series of tests to verify/demonstrate correctness
 - documentation of the API, porcelain and core concepts

In cold starts rev-cache has sped up packing and walking by a factor of 4, and over twice that on warm starts. Some times on slax for the linux repository:

rev-list --all --objects >/dev/null
 default
   cold    1:13
   warm    0:43
 rev-cache'd
   cold    0:19
   warm    0:02
pack-objects --revs --all --stdout >/dev/null
 default
   cold    2:44
   warm    1:21
 rev-cache'd
   cold    0:44
   warm    0:10

The mechanism is minimally intrusive: most of the changes take place in seperate files, and only a handful of git's existing functions are modified.

Hope you find this useful.
 - Nick
---
BOMBS AWAY!!!
To clarify my magnificent muddying of this final update I'm flash flooding y'all with a mint patchset!  This probably isn't deserving of it's own version, but it's the last one and I've confuddled everyone enough already.
SO, what's changed from the last one?
 - fixed whitespace errors
 - cleaned up header definitions
 - implemented _ondisk versions of structs for ensured portability
 - fixed typo
Sorry again for the size of the patches, but like I said earlier they're not so much patches as files -- the changes in existing git files are actually pretty small.  Since most everything in the patches is intertwined I couldn't split it up a bunch more without having non-functioning patches.
I promise this is the last one :-P
 Documentation/git-rev-cache.txt       |  144 ++
 Documentation/technical/rev-cache.txt |  614 +++++++++
 Makefile                              |    2 +
 builtin-gc.c                          |    9 +
 builtin-rev-cache.c                   |  322 +++++
 builtin.h                             |    1 +
 commit.c                              |    2 +
 git.c                                 |    1 +
 list-objects.c                        |   49 +-
 rev-cache.c                           | 2314 +++++++++++++++++++++++++++++++++
 rev-cache.h                           |  124 ++
 revision.c                            |   90 +-
 revision.h                            |   44 +-
 t/t6015-rev-cache-list.sh             |  251 ++++
 14 files changed, 3942 insertions(+), 25 deletions(-)
 create mode 100644 Documentation/git-rev-cache.txt
 create mode 100644 Documentation/technical/rev-cache.txt
 create mode 100644 builtin-rev-cache.c
 create mode 100644 rev-cache.c
 create mode 100644 rev-cache.h
 create mode 100755 t/t6015-rev-cache-list.sh
Nick Edelen· Aug 18, 2009, 11:51 UTC · re: Nick Edelen · lore

Re: [PATCH 0/6 (v4)] revision caching mechanism to significantly speed up packing/walking (last version)

SUGGESTED FOR 'PU':

Traversing objects is currently very costly, as every commit and tree must be loaded and parsed. Much time and energy could be saved by caching metadata and topological info in an efficient, easily accessible manner. Furthermore, this could improve git's interfacing potential, by providing a condensed summary of a repository's commit tree.

This is a series to implement such a revision caching mechanism, aptly named
rev-cache.  The series will provide:
 - a core API to manipulate and traverse caches
 - an integration into the internal revision walker
 - a porcelain front-end providing access to users and (shell) applications
 - a series of tests to verify/demonstrate correctness
 - documentation of the API, porcelain and core concepts

In cold starts rev-cache has sped up packing and walking by a factor of 4, and over twice that on warm starts. Some times on slax for the linux repository:

rev-list --all --objects >/dev/null
 default
   cold    1:13
   warm    0:43
 rev-cache'd
   cold    0:19
   warm    0:02
pack-objects --revs --all --stdout >/dev/null
 default
   cold    2:44
   warm    1:21
 rev-cache'd
   cold    0:44
   warm    0:10

The mechanism is minimally intrusive: most of the changes take place in seperate files, and only a handful of git's existing functions are modified.

Hope you find this useful.
 - Nick

--- Ok, this really is the last time I send all these.

 Documentation/git-rev-cache.txt       |  162 +++
 Documentation/technical/rev-cache.txt |  614 +++++++++
 Makefile                              |    2 +
 builtin-gc.c                          |    9 +
 builtin-rev-cache.c                   |  323 +++++
 builtin.h                             |    1 +
 commit.c                              |    2 +
 git.c                                 |    1 +
 list-objects.c                        |   49 +-
 rev-cache.c                           | 2316 +++++++++++++++++++++++++++++++++
 rev-cache.h                           |  124 ++
 revision.c                            |   90 +-
 revision.h                            |   44 +-
 t/t6015-rev-cache-list.sh             |  251 ++++
 14 files changed, 3963 insertions(+), 25 deletions(-)
 create mode 100644 Documentation/git-rev-cache.txt
 create mode 100644 Documentation/technical/rev-cache.txt
 create mode 100644 builtin-rev-cache.c
 create mode 100644 rev-cache.c
 create mode 100644 rev-cache.h
 create mode 100755 t/t6015-rev-cache-list.sh

← back to recent threads