[PATCH] git submodule foreach: Provide access to submodule name, as '$name'

Johan Herland· Aug 16, 2009, 01:10 UTC · lore

The argument to 'git submodule foreach' already has access to the variables '$path' (the path to the submodule, relative to the superproject) and '$sha1' (the submodule commit recorded by the superproject).

This patch adds another variable -- '$name' -- which contains the name of the submodule, as recorded in the superproject's .gitmodules file.

Signed-off-by: Johan Herland <johan@herland.net>
---
 Documentation/git-submodule.txt |    3 ++-
 git-submodule.sh                |    1 +
 2 files changed, 3 insertions(+), 1 deletions(-)

Show changes to 2 files +3 −1

Documentation/git-submodule.txt, git-submodule.sh

diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
index 7dd73ae..97c32fe 100644
--- a/Documentation/git-submodule.txt
+++ b/Documentation/git-submodule.txt
@@ -131,7 +131,8 @@ summary::
 
 foreach::
 	Evaluates an arbitrary shell command in each checked out submodule.
-	The command has access to the variables $path and $sha1:
+	The command has access to the variables $name, $path and $sha1:
+	$name is the name of the relevant submodule section in .gitmodules,
 	$path is the name of the submodule directory relative to the
 	superproject, and $sha1 is the commit as recorded in the superproject.
 	Any submodules defined in the superproject but not checked out are
diff --git a/git-submodule.sh b/git-submodule.sh
index ebed711..d8ecdb9 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -243,6 +243,7 @@ cmd_foreach()
 		if test -e "$path"/.git
 		then
 			say "Entering '$path'"
+			name=$(module_name "$path")
 			(cd "$path" && eval "$@") ||
 			die "Stopping at '$path'; script returned non-zero status."
 		fi

-- 
1.6.4.rc3.138.ga6b98.dirty

Mark Levedahl· Aug 18, 2009, 00:54 UTC · re: Johan Herland · lore

Re: [PATCH] git submodule foreach: Provide access to submodule name, as '$name'

Johan Herland wrote:

Show 10 quoted lines

> The argument to 'git submodule foreach' already has access to the variables
> '$path' (the path to the submodule, relative to the superproject) and '$sha1'
> (the submodule commit recorded by the superproject).
>
> This patch adds another variable -- '$name' -- which contains the name of the
> submodule, as recorded in the superproject's .gitmodules file.
>
> Signed-off-by: Johan Herland <johan@herland.net>
> ---
>

This patch *looks* ok to me, but I'm out of the office for most of August so I cannot actually test this code for another couple of weeks.

Mark

patchgit submodule foreach: Provide access to submodule name, as '$name'