threads / discuss / 20599

Re: trailling whitespace with git am ?

Subject: Re: trailling whitespace with git am ?

## tl;dr

2 messages between Aug 14, 2009 and Aug 14, 2009.

replies: 1people: 2as markdown or json

Alex Riesen· Aug 14, 2009, 21:43 UTC · lore

On Fri, Aug 14, 2009 at 22:50, PICCA Frédéric-Emmanuel<frederic-emmanuel.picca@synchrotron-soleil.fr> wrote:

Show 7 quoted lines

>> > git am --whitespace=fix was sufficient to apply the patch
>
>> Depending on your situation it can be an overkill: it'll remove _all_ trailing
>> white space. Not just \r (CR).
>
> so /s /t and /r are the same things for git ?
>

almost. For git-apply's whitespace fixing code. Why?

PICCA Frédéric-Emmanuel· Aug 14, 2009, 21:50 UTC · re: Alex Riesen · lore

RE : trailling whitespace with git am ?

> > so /s /t and /r are the same things for git ?

> almost. For git-apply's whitespace fixing code. Why?

Because for the user the message trailling whitespace was not clear In fact the problem was a dos/unix format not a trailling space.

but whitespace=fix solve this problem. I was surprise first because I was looking for remaining space at the end of lines of the patch not this CR+LF things.

Maybe git apply should warn the user a different way if their is that sort of dos/unix imcompatibilities.

thanks

Frederic