# [PATCH 7/9] update 'git-show' bash completion to match the man page 2 messages from 2009-08-08 to 2009-08-08. Participants: Emmanuel Trillaud, Junio C Hamano. Thread: https://gitlist.dev/t/20478 ## Emmanuel Trillaud, 2009-08-08 08:56 Subject: [PATCH 7/9] update 'git-show' bash completion to match the man page Message-ID: <9f50533b0908080156j33db6f99u18de79537677451b@mail.gmail.com> URL: https://gitlist.dev/e/9f50533b0908080156j33db6f99u18de79537677451b%40mail.gmail.com ``` Signed-off-by: Emmanuel Trillaud --- contrib/completion/git-completion.bash | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 4746eee..1e3efe3 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -1870,7 +1870,7 @@ _git_show () return ;; --*) - __gitcomp "--pretty= --format= --abbrev-commit --oneline + __gitcomp "--pretty= --format= --abbrev-commit --oneline --encoding $__git_diff_common_options " return -- 1.6.4 ``` ## Junio C Hamano, 2009-08-08 19:49 Subject: Re: [PATCH 7/9] update 'git-show' bash completion to match the man page Message-ID: <7vfxc2dr19.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vfxc2dr19.fsf%40alter.siamese.dyndns.org In-Reply-To: <9f50533b0908080156j33db6f99u18de79537677451b@mail.gmail.com> ``` Emmanuel Trillaud writes: > Signed-off-by: Emmanuel Trillaud What did you add? > - __gitcomp "--pretty= --format= --abbrev-commit --oneline > + __gitcomp "--pretty= --format= --abbrev-commit --oneline --encoding Is it not "--encoding="? If not, why not? ```