# [PATCH 6/9] update 'git-rm' bash completion according to the man page 3 messages from 2009-08-08 to 2009-08-08. Participants: Emmanuel Trillaud, Junio C Hamano. Thread: https://gitlist.dev/t/20477 ## Emmanuel Trillaud, 2009-08-08 08:56 Subject: [PATCH 6/9] update 'git-rm' bash completion according to the man page Message-ID: <9f50533b0908080156t7cfd05ebg3e5d29f7d2260c25@mail.gmail.com> URL: https://gitlist.dev/e/9f50533b0908080156t7cfd05ebg3e5d29f7d2260c25%40mail.gmail.com ``` Signed-off-by: Emmanuel Trillaud --- contrib/completion/git-completion.bash | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 98e1185..4746eee 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -1828,7 +1828,7 @@ _git_rm () local cur="${COMP_WORDS[COMP_CWORD]}" case "$cur" in --*) - __gitcomp "--cached --dry-run --ignore-unmatch --quiet" + __gitcomp "--force --cached --dry-run --ignore-unmatch --quiet" return ;; esac -- 1.6.4 ``` ## Junio C Hamano, 2009-08-08 19:49 Subject: Re: [PATCH 6/9] update 'git-rm' bash completion according to the man page Message-ID: <7vljludr2d.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vljludr2d.fsf%40alter.siamese.dyndns.org In-Reply-To: <9f50533b0908080156t7cfd05ebg3e5d29f7d2260c25@mail.gmail.com> ``` Emmanuel Trillaud writes: > Signed-off-by: Emmanuel Trillaud Description of what you did? > - __gitcomp "--cached --dry-run --ignore-unmatch --quiet" > + __gitcomp "--force --cached --dry-run --ignore-unmatch --quiet" I thought not completing --force to allow a dangerous operation was a conscious decision. ``` ## Emmanuel Trillaud, 2009-08-08 20:33 Subject: Re: [PATCH 6/9] update 'git-rm' bash completion according to the man page Message-ID: <20090808223312.75ba3d10@eleanor> URL: https://gitlist.dev/e/20090808223312.75ba3d10%40eleanor In-Reply-To: <7vljludr2d.fsf@alter.siamese.dyndns.org> ``` > > - __gitcomp "--cached --dry-run --ignore-unmatch > > --quiet" > > + __gitcomp "--force --cached --dry-run > > --ignore-unmatch --quiet" > > I thought not completing --force to allow a dangerous operation was a > conscious decision. For me, completion as always been a reminder for options I forgot (or I think they exist) and I use short options when I know them because it is easier to type. So IMHO '--force' is a useful option that deserve to be complete. But if you make a conscious decision in the past to not complete '--force', I won't fight :-) and I will just add a comment in the git-completion script for the guys like me who think it is missing. Best regard Emmanuel ```