# [PATCH] Check return value of ftruncate call in http.c. Remove possible mem leak 2 messages from 2009-08-08 to 2009-08-10. Participants: Jeff Lasslett, Junio C Hamano. Thread: https://gitlist.dev/t/20463 ## Jeff Lasslett, 2009-08-08 05:38 Subject: [PATCH] Check return value of ftruncate call in http.c. Remove possible mem leak Message-ID: <1249709881-31334-1-git-send-email-jeff.lasslett@gmail.com> URL: https://gitlist.dev/e/1249709881-31334-1-git-send-email-jeff.lasslett%40gmail.com ``` In new_http_object_request(), check ftruncate() call return value and handle possible errors. Remove possible leak of mem pointed to by url. Signed-off-by: Jeff Lasslett --- http.c | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/http.c b/http.c index a2720d5..34a3a35 100644 --- a/http.c +++ b/http.c @@ -1098,7 +1098,7 @@ struct http_object_request *new_http_object_request(const char *base_url, char *hex = sha1_to_hex(sha1); char *filename; char prevfile[PATH_MAX]; - char *url; + char *url = NULL; int prevlocal; unsigned char prev_buf[PREV_BUF_SIZE]; ssize_t prev_read = 0; @@ -1189,7 +1189,11 @@ struct http_object_request *new_http_object_request(const char *base_url, if (prev_posn>0) { prev_posn = 0; lseek(freq->localfile, 0, SEEK_SET); - ftruncate(freq->localfile, 0); + if (ftruncate(freq->localfile, 0) < 0) { + error("Couldn't truncate temporary file %s for %s: %s", + freq->tmpfile, freq->filename, strerror(errno)); + goto abort; + } } } @@ -1216,10 +1220,12 @@ struct http_object_request *new_http_object_request(const char *base_url, CURLOPT_HTTPHEADER, range_header); } + free(url); return freq; - free(url); abort: + free(url); + free(freq->url); free(filename); free(freq); return NULL; -- 1.6.4.59.g4d590.dirty ``` ## Junio C Hamano, 2009-08-10 01:54 Subject: Re: [PATCH] Check return value of ftruncate call in http.c. Remove possible mem leak Message-ID: <7vljls5t7u.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vljls5t7u.fsf%40alter.siamese.dyndns.org In-Reply-To: <1249709881-31334-1-git-send-email-jeff.lasslett@gmail.com> ``` Jeff Lasslett writes: > In new_http_object_request(), check ftruncate() call return value and > handle possible errors. Remove possible leak of mem pointed to by url. Are you assuming that everybody is running libcurl 7.17.0 or later? Before that version strings given to easy_setopt() were not copied and you needed to keep them around. I think freeing url is fine but you would probably need to then give freq->url to easy_setopt(CURLOPT_URL) if you wanted to do so. ```