# Problem compiling git-1.6.4 on OpenServer 6.0 7 messages from 2009-08-07 to 2009-08-08. Participants: Boyd Lynn Gerber, Junio C Hamano, Brandon Casey. Thread: https://gitlist.dev/t/20454 ## Boyd Lynn Gerber, 2009-08-07 19:27 Subject: Problem compiling git-1.6.4 on OpenServer 6.0 Message-ID: URL: https://gitlist.dev/e/alpine.LNX.2.00.0908071326250.13290%40suse104.zenez.com ``` Hello, I just tried to compile the latest git and I get this error. CC builtin-pack-objects.o UX:acomp: ERROR: "builtin-pack-objects.c", line 1602: integral constant expression expected gmake: *** [builtin-pack-objects.o] Error 1 I will look into it when I have a bit more time, but this is a heads up. Thanks, -- Boyd Gerber 801 849-0213 ZENEZ 1042 East Fort Union #135, Midvale Utah 84047 ``` ## Junio C Hamano, 2009-08-07 20:07 Subject: Re: Problem compiling git-1.6.4 on OpenServer 6.0 Message-ID: <7v8whvv142.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7v8whvv142.fsf%40alter.siamese.dyndns.org In-Reply-To: ``` Boyd Lynn Gerber writes: > I just tried to compile the latest git and I get this error. > > CC builtin-pack-objects.o > UX:acomp: ERROR: "builtin-pack-objects.c", line 1602: integral > constant expression expected I think we recently acquired another instance of variable sized array on the stack in addition to this one. ``` ## Brandon Casey, 2009-08-07 20:53 Subject: Re: Problem compiling git-1.6.4 on OpenServer 6.0 Message-ID: URL: https://gitlist.dev/e/cY-iS6BS6knyjPKeVQI3ZIsIw3A3y5VK1oW-MNzUUztRn8CbeqRdew%40cipher.nrlssc.navy.mil In-Reply-To: ``` Boyd Lynn Gerber wrote: > Hello, > > I just tried to compile the latest git and I get this error. > > CC builtin-pack-objects.o > UX:acomp: ERROR: "builtin-pack-objects.c", line 1602: integral constant > expression expected > gmake: *** [builtin-pack-objects.o] Error 1 > > I will look into it when I have a bit more time, but this is a heads up. Did you set THREADED_DELTA_SEARCH=1 when you compiled? That could be the problem. Line 1602 of builtin-pack-objects.c is wrapped in #ifdef THREADED_DELTA_SEARCH, so it is only compiled if THREADED_DELTA_SEARCH has been set. Also, it's not a new line, it has been around since 2007. -brandon ``` ## Boyd Lynn Gerber, 2009-08-07 21:15 Subject: Re: Problem compiling git-1.6.4 on OpenServer 6.0 Message-ID: URL: https://gitlist.dev/e/alpine.LNX.2.00.0908071511390.13290%40suse104.zenez.com In-Reply-To: ``` On Fri, 7 Aug 2009, Brandon Casey wrote: > Boyd Lynn Gerber wrote: >> >> I just tried to compile the latest git and I get this error. >> >> CC builtin-pack-objects.o >> UX:acomp: ERROR: "builtin-pack-objects.c", >> line 1602: integral constant expression expected gmake: *** >> [builtin-pack-objects.o] Error 1 >> >> I will look into it when I have a bit more time, but this is a heads up. > > Did you set THREADED_DELTA_SEARCH=1 when you compiled? That could be > the problem. > > Line 1602 of builtin-pack-objects.c is wrapped in #ifdef THREADED_DELTA_SEARCH, > so it is only compiled if THREADED_DELTA_SEARCH has been set. Also, it's not > a new line, it has been around since 2007. Yes, that is the problem it was set. The OS has kernel threads and all must be accessed by -Kthread and no -pthread when linking. Thanks for the hnt... -- Boyd Gerber 801 849-0213 ZENEZ 1042 East Fort Union #135, Midvale Utah 84047 ``` ## Boyd Lynn Gerber, 2009-08-07 21:25 Subject: Re: Problem compiling git-1.6.4 on OpenServer 6.0 Message-ID: URL: https://gitlist.dev/e/alpine.LNX.2.00.0908071523550.13290%40suse104.zenez.com In-Reply-To: ``` On Fri, 7 Aug 2009, Brandon Casey wrote: > Boyd Lynn Gerber wrote: >> I just tried to compile the latest git and I get this error. >> >> CC builtin-pack-objects.o >> UX:acomp: ERROR: "builtin-pack-objects.c", line 1602: integral constant >> expression expected >> gmake: *** [builtin-pack-objects.o] Error 1 >> >> I will look into it when I have a bit more time, but this is a heads up. > > Did you set THREADED_DELTA_SEARCH=1 when you compiled? That could be the > problem. > > Line 1602 of builtin-pack-objects.c is wrapped in #ifdef THREADED_DELTA_SEARCH, > so it is only compiled if THREADED_DELTA_SEARCH has been set. Also, it's not > a new line, it has been around since 2007. Removing it and the -pthread allows it to build. I am now running the tests. The I need to find out why it is being set. Thanks, -- Boyd Gerber 801 849-0213 ZENEZ 1042 East Fort Union #135, Midvale Utah 84047 ``` ## Brandon Casey, 2009-08-07 21:36 Subject: Re: Problem compiling git-1.6.4 on OpenServer 6.0 Message-ID: URL: https://gitlist.dev/e/DHem56NUSFhg2VqQu1N0qVr3U86qJOp4OZZAEwV2Edz0-YuWJpDtgA%40cipher.nrlssc.navy.mil In-Reply-To: ``` Boyd Lynn Gerber wrote: > On Fri, 7 Aug 2009, Brandon Casey wrote: >> Boyd Lynn Gerber wrote: >>> I just tried to compile the latest git and I get this error. >>> >>> CC builtin-pack-objects.o >>> UX:acomp: ERROR: "builtin-pack-objects.c", line 1602: integral constant >>> expression expected >>> gmake: *** [builtin-pack-objects.o] Error 1 >>> >>> I will look into it when I have a bit more time, but this is a heads up. >> >> Did you set THREADED_DELTA_SEARCH=1 when you compiled? That could be the >> problem. >> >> Line 1602 of builtin-pack-objects.c is wrapped in #ifdef >> THREADED_DELTA_SEARCH, >> so it is only compiled if THREADED_DELTA_SEARCH has been set. Also, >> it's not >> a new line, it has been around since 2007. > > Removing it and the -pthread allows it to build. I am now running the > tests. The I need to find out why it is being set. Did you run configure? which generates a config.mak.autogen file? There were some changes related to pthreads in configure.ac in March, and another back in Nov 2008. Specifically commits 1973b0d7, and d937c374. -brandon ``` ## Boyd Lynn Gerber, 2009-08-08 16:14 Subject: Re: Problem compiling git-1.6.4 on OpenServer 6.0 Message-ID: URL: https://gitlist.dev/e/alpine.LNX.2.00.0908081013090.13290%40suse104.zenez.com In-Reply-To: ``` On Fri, 7 Aug 2009, Brandon Casey wrote: > Boyd Lynn Gerber wrote: >> On Fri, 7 Aug 2009, Brandon Casey wrote: >>> Boyd Lynn Gerber wrote: >>>> I just tried to compile the latest git and I get this error. >>>> >>>> CC builtin-pack-objects.o >>>> UX:acomp: ERROR: "builtin-pack-objects.c", line 1602: integral constant >>>> expression expected >>>> gmake: *** [builtin-pack-objects.o] Error 1 >>>> >>>> I will look into it when I have a bit more time, but this is a heads up. >>> >>> Did you set THREADED_DELTA_SEARCH=1 when you compiled? That could be the >>> problem. >>> >>> Line 1602 of builtin-pack-objects.c is wrapped in #ifdef >>> THREADED_DELTA_SEARCH, >>> so it is only compiled if THREADED_DELTA_SEARCH has been set. Also, >>> it's not >>> a new line, it has been around since 2007. >> >> Removing it and the -pthread allows it to build. I am now running the >> tests. The I need to find out why it is being set. > > Did you run configure? which generates a config.mak.autogen file? > There were some changes related to pthreads in configure.ac in March, > and another back in Nov 2008. Specifically commits 1973b0d7, and > d937c374. Yes, I am working through them and will submit a patch once I get it working properly without breaking someone elses configuration. Thanks, -- Boyd Gerber 801 849-0213 ZENEZ 1042 East Fort Union #135, Midvale Utah 84047 ```