threads / patch / 20313

patchstgit new: Do not open editor if --save-template was specified

Subject: [StGit PATCH] stgit new: Do not open editor if --save-template was specified

## tl;dr

One message between Jul 31, 2009 and Jul 31, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Gustav Hållberg· Jul 31, 2009, 09:48 UTC · lore
Fixes side-effect of e58f264a3e59a0887c7aaa1e3227cff108ac840d

I'm not sure this is the right way to fix the problem, but an editor should not be opened if "--save-template" was specified to "stg new", as it is used for batch processes.

Signed-off-by: Gustav Hållberg <gustav@virtutech.com>
---
 stgit/commands/new.py |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Show changes to stgit/commands/new.py +2 −1
diff --git a/stgit/commands/new.py b/stgit/commands/new.py
index 9fd51c3..158193e 100644
--- a/stgit/commands/new.py
+++ b/stgit/commands/new.py
@@ -67,7 +67,8 @@ def func(parser, options, args):
     cd = gitlib.CommitData(
         tree = stack.head.data.tree, parents = [stack.head], message = '',
         author = gitlib.Person.author(), committer = gitlib.Person.committer())
-    cd = common.update_commit_data(cd, options, allow_edit = True)
+    cd = common.update_commit_data(cd, options,
+                                   allow_edit = not options.save_template)
 
     if options.save_template:
         options.save_template(cd.message)

← back to recent threads