threads / patch / 20298

patchcheckout: hide progress bar when stderr is not a tty

Subject: [PATCH] checkout: hide progress bar when stderr is not a tty

## tl;dr

One message between Jul 30, 2009 and Jul 30, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Michal Marek· Jul 30, 2009, 16:13 UTC · lore

The correct fix would be in start_progress_delay(), however this breaks the progress bar for fetch/push via ssh. So fix it in this caller which will always run locally.

Signed-off-by: Michal Marek <mmarek@suse.cz>
---
 unpack-trees.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to unpack-trees.c +1 −1
diff --git a/unpack-trees.c b/unpack-trees.c
index 720f7a1..a11f559 100644
--- a/unpack-trees.c
+++ b/unpack-trees.c
@@ -75,7 +75,7 @@ static int check_updates(struct unpack_trees_options *o)
 	int i;
 	int errs = 0;
 
-	if (o->update && o->verbose_update) {
+	if (o->update && o->verbose_update && isatty(STDERR_FILENO)) {
 		for (total = cnt = 0; cnt < index->cache_nr; cnt++) {
 			struct cache_entry *ce = index->cache[cnt];
 			if (ce->ce_flags & (CE_UPDATE | CE_REMOVE))
-- 
1.6.4.13.ge6580.dirty

← back to recent threads