threads / patch / 2017

patchcvsimport: don't pass --cvs-direct if user options contradict us

Subject: [PATCH] cvsimport: don't pass --cvs-direct if user options contradict us

## tl;dr

One message between Oct 5, 2005 and Oct 5, 2005. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Martin Langhoff· Oct 5, 2005, 10:46 UTC · lore

Detecting if the user passed --no-cvs-direct and don't force the mode. It allows us to support all the protocol that the standard cvs client supports at the snail speed you should expect.

This only affects the rlog reading stage.
Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
---
 git-cvsimport.perl |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
35587b31ee78ae96a54b10107c5ea3ce21eaa6b1
Show changes to git-cvsimport.perl +4 −1
diff --git a/git-cvsimport.perl b/git-cvsimport.perl
--- a/git-cvsimport.perl
+++ b/git-cvsimport.perl
@@ -487,7 +487,10 @@ unless($pid) {
 	my @opt;
 	@opt = split(/,/,$opt_p) if defined $opt_p;
 	unshift @opt, '-z', $opt_z if defined $opt_z;
-	exec("cvsps",@opt,"-u","-A","--cvs-direct",'--root',$opt_d,$cvs_tree);
+	unless ($opt_p =~ m/--no-cvs-direct/) {
+		push @opt, '--cvs-direct';
+	}
+	exec("cvsps",@opt,"-u","-A",'--root',$opt_d,$cvs_tree);
 	die "Could not start cvsps: $!\n";
 }
 

← back to recent threads