threads / patch / 20130

patchAdded support for core.ignorecase when excluding gitignore entries

Subject: [PATCH] Added support for core.ignorecase when excluding gitignore entries

## tl;dr

5 messages between Jul 16, 2009 and Jul 21, 2009. Diffs are folded; open one to read it.

replies: 4people: 2as markdown or json

Joshua Jensen· Jul 16, 2009, 05:19 UTC · lore

This patch allows core.ignorecase=true to work properly with gitignore exclusions.

This is especially beneficial when using Windows and Perforce and the git-p4 bridge. Perforce preserves a given file's full path including case. When syncing a file down, directories are created, if necessary, using the case as stored with the filename. Unfortunately, two files in the same directory can have differing cases for their respective paths, such as /dirA/file1.c and /DirA/file2.c. Depending on sync order, DirA/ may get created instead of dirA/.

Trying to catch all case combinations for a set of gitignore entries is 
very difficult.  Having the exclusions honor the core.ignorecase=true 
makes the process less error prone.
---
 dir.c |   49 ++++++++++++++++++++++++++++++++++++-------------
 1 files changed, 36 insertions(+), 13 deletions(-)
Show changes to dir.c +36 −14
diff --git a/dir.c b/dir.c
index 0e6b752..c63e0a0 100644
--- a/dir.c
+++ b/dir.c
@@ -315,14 +315,25 @@ static int excluded_1(const char *pathname,
             if (x->flags & EXC_FLAG_NODIR) {
                 /* match basename */
                 if (x->flags & EXC_FLAG_NOWILDCARD) {
-                    if (!strcmp(exclude, basename))
-                        return to_exclude;
+                    if (ignore_case) {
+                        if (!strcasecmp(exclude, basename))
+                            return to_exclude;
+                    } else {
+                        if (!strcmp(exclude, basename))
+                            return to_exclude;
+                    }
                 } else if (x->flags & EXC_FLAG_ENDSWITH) {
-                    if (x->patternlen - 1 <= pathlen &&
-                        !strcmp(exclude + 1, pathname + pathlen - 
x->patternlen + 1))
-                        return to_exclude;
+                    if (ignore_case) {
+                        if (x->patternlen - 1 <= pathlen &&
+                            !strcasecmp(exclude + 1, pathname + pathlen 
- x->patternlen + 1))
+                            return to_exclude;
+                    } else {
+                        if (x->patternlen - 1 <= pathlen &&
+                            !strcmp(exclude + 1, pathname + pathlen - 
x->patternlen + 1))
+                            return to_exclude;
+                    }
                 } else {
-                    if (fnmatch(exclude, basename, 0) == 0)
+                    if (fnmatch(exclude, basename, ignore_case ? 
FNM_CASEFOLD : 0) == 0)
                         return to_exclude;
                 }
             }
@@ -335,17 +346,29 @@ static int excluded_1(const char *pathname,
                 if (*exclude == '/')
                     exclude++;
 
-                if (pathlen < baselen ||
-                    (baselen && pathname[baselen-1] != '/') ||
-                    strncmp(pathname, x->base, baselen))
-                    continue;
+                if (ignore_case) {
+                    if (pathlen < baselen ||
+                        (baselen && pathname[baselen-1] != '/') ||
+                        strncasecmp(pathname, x->base, baselen))
+                        continue;
+                } else {
+                    if (pathlen < baselen ||
+                        (baselen && pathname[baselen-1] != '/') ||
+                        strncmp(pathname, x->base, baselen))
+                        continue;
+                }
 
                 if (x->flags & EXC_FLAG_NOWILDCARD) {
-                    if (!strcmp(exclude, pathname + baselen))
-                        return to_exclude;
+                    if (ignore_case) {
+                        if (!strcasecmp(exclude, pathname + baselen))
+                            return to_exclude;
+                    } else {
+                        if (!strcmp(exclude, pathname + baselen))
+                            return to_exclude;
+                    }
                 } else {
                     if (fnmatch(exclude, pathname+baselen,
-                            FNM_PATHNAME) == 0)
+                            FNM_PATHNAME | (ignore_case ? FNM_CASEFOLD 
: 0)) == 0)
                         return to_exclude;
                 }
             }

-- 
1.6.3.2.1299.gee46c.dirty
Jeff King· Jul 16, 2009, 09:42 UTC · re: Joshua Jensen · lore

Re: [PATCH] Added support for core.ignorecase when excluding gitignore entries

On Wed, Jul 15, 2009 at 11:19:05PM -0600, Joshua Jensen wrote:
> This patch allows core.ignorecase=true to work properly with
> gitignore exclusions.

Makes sense, though I can't help but wonder what would happen with a filesystem that did more than just case (like the utf8 normalization that happens on HFS).

Should we actually be converting the filesystem names into a canonical format as they are read? IIRC, Linus posted some patches a few weeks ago about "git path" versus "filesystem path", but I didn't actually look too closely.

That seems like the right way forward to fixing these problems in the long term, but it may make sense to do something like your patch in the meantime.

Show 14 quoted lines
> -                        !strcmp(exclude + 1, pathname + pathlen -
> x->patternlen + 1))
> -                        return to_exclude;
> +                    if (ignore_case) {
> +                        if (x->patternlen - 1 <= pathlen &&
> +                            !strcasecmp(exclude + 1, pathname +
> pathlen - x->patternlen + 1))
> +                            return to_exclude;
> +                    } else {
> +                        if (x->patternlen - 1 <= pathlen &&
> +                            !strcmp(exclude + 1, pathname + pathlen
> - x->patternlen + 1))
> +                            return to_exclude;
> +                    }

If your patch is the right route, it might be nice to collapse the comparison into its own function. You end up cutting and pasting a lot of the related conditionals and returns (like above, where 2 lines become 9), so it might make sense to do something like:

  int filename_cmp(const char *a, const char *b, int ignore_case)
  {
    return ignore_case ? strcasecmp(a, b) : strcmp(a, b);
  }
and then just s/strcmp/filename_cmp/ at the appropriate callsites.
-Peff
Joshua Jensen· Jul 16, 2009, 13:15 UTC · re: Jeff King · lore

Re: [PATCH] Added support for core.ignorecase when excluding gitignore entries

----- Original Message -----
From: Jeff King
Date: 7/16/2009 3:42 AM
Show 9 quoted lines
> Makes sense, though I can't help but wonder what would happen with a
> filesystem that did more than just case (like the utf8 normalization
> that happens on HFS).
>
> Should we actually be converting the filesystem names into a canonical
> format as they are read? IIRC, Linus posted some patches a few weeks ago
> about "git path" versus "filesystem path", but I didn't actually look
> too closely.
>

I'm game for whatever. Git actually has a lot of places where it doesn't pay attention to core.ignorecase, and having a standard and correct method of comparing filenames would make it easier to handle core.ignorecase=true in a more global fashion.

Show 12 quoted lines
> If your patch is the right route, it might be nice to collapse the
> comparison into its own function. You end up cutting and pasting a lot
> of the related conditionals and returns (like above, where 2 lines
> become 9), so it might make sense to do something like:
>
>   int filename_cmp(const char *a, const char *b, int ignore_case)
>   {
>     return ignore_case ? strcasecmp(a, b) : strcmp(a, b);
>   }
>
> and then just s/strcmp/filename_cmp/ at the appropriate callsites.
>

I started off with this method, but it required two functions, one with the strcmp() and one for strncmp(). In fact, in other places in the code, Git uses memcmp() for comparison. Is that, then, three filename comparison functions, dependent upon intent? At that point, it felt like my change wasn't as self contained anymore, so I then wrote what I posted to the list to get feedback.

I'm hoping someone will offer the most correct method to do this, as I have a number of patches forthcoming to handle core.ignorecase=true in other areas. The next one covers 'git status' and its reporting of 'missing' directories due to case differences.

Thanks!
Josh
Jeff King· Jul 20, 2009, 15:37 UTC · re: Joshua Jensen · lore

Re: [PATCH] Added support for core.ignorecase when excluding gitignore entries

On Thu, Jul 16, 2009 at 07:15:26AM -0600, Joshua Jensen wrote:
Show 8 quoted lines
> >Should we actually be converting the filesystem names into a canonical
> >format as they are read? IIRC, Linus posted some patches a few weeks ago
> >about "git path" versus "filesystem path", but I didn't actually look
> >too closely.
> I'm game for whatever.  Git actually has a lot of places where it
> doesn't pay attention to core.ignorecase, and having a standard and
> correct method of comparing filenames would make it easier to handle
> core.ignorecase=true in a more global fashion.

Like I said, I'm not sure what the status of that is, so probably something simple like your patch makes sense in the interim (unless we hear from somebody more clueful).

Show 17 quoted lines
> >If your patch is the right route, it might be nice to collapse the
> >comparison into its own function. You end up cutting and pasting a lot
> >of the related conditionals and returns (like above, where 2 lines
> >become 9), so it might make sense to do something like:
> >
> >  int filename_cmp(const char *a, const char *b, int ignore_case)
> >  {
> >    return ignore_case ? strcasecmp(a, b) : strcmp(a, b);
> >  }
> >
> >and then just s/strcmp/filename_cmp/ at the appropriate callsites.
> I started off with this method, but it required two functions, one
> with the strcmp() and one for strncmp().  In fact, in other places in
> the code, Git uses memcmp() for comparison.  Is that, then, three
> filename comparison functions, dependent upon intent?  At that point,
> it felt like my change wasn't as self contained anymore, so I then
> wrote what I posted to the list to get feedback.

IMHO, you are better off even with three wrapper functions, just because they are all very straightforward. Whereas with your patch, I felt like the innards of complex functions got harder to read because of big duplicate conditionals. But that's just my two cents.

-Peff
Joshua Jensen· Jul 21, 2009, 15:55 UTC · re: Jeff King · lore

Re: [PATCH] Added support for core.ignorecase when excluding gitignore entries

----- Original Message -----
From: Jeff King
Date: 7/20/2009 9:37 AM
Show 17 quoted lines
>>> If your patch is the right route, it might be nice to collapse the
>>> comparison into its own function. You end up cutting and pasting a lot
>>> of the related conditionals and returns (like above, where 2 lines
>>> become 9), so it might make sense to do something like:
>>>
>>>  int filename_cmp(const char *a, const char *b, int ignore_case)
>>>  {
>>>    return ignore_case ? strcasecmp(a, b) : strcmp(a, b);
>>>  }
>>>
>>> and then just s/strcmp/filename_cmp/ at the appropriate callsites.
>>>       
> IMHO, you are better off even with three wrapper functions, just because
> they are all very straightforward. Whereas with your patch, I felt like
> the innards of complex functions got harder to read because of big
> duplicate conditionals. But that's just my two cents.
>   
I agree.  I will update the patch soon.
Josh

← back to recent threads