threads / patch / 20082

patchAllow author names with just two letters.

Subject: [PATCH] Allow author names with just two letters.

## tl;dr

2 messages between Jul 10, 2009 and Jul 29, 2009. Diffs are folded; open one to read it.

replies: 1people: 1as markdown or json

Oswald Buddenhagen· Jul 10, 2009, 20:01 UTC · lore
Some at Qt Software use aliases which may have only two letters.
One could argue that just one letter should be permitted as well,
but that's none of my concerns. :)
---
 builtin-mailinfo.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to builtin-mailinfo.c +1 −1
diff --git a/builtin-mailinfo.c b/builtin-mailinfo.c
index 1eeeb4d..1adbebd 100644
--- a/builtin-mailinfo.c
+++ b/builtin-mailinfo.c
@@ -35,7 +35,7 @@ static void cleanup_space(struct strbuf *sb);
 static void get_sane_name(struct strbuf *out, struct strbuf *name, struct strbuf *email)
 {
 	struct strbuf *src = name;
-	if (name->len < 3 || 60 < name->len || strchr(name->buf, '@') ||
+	if (name->len < 2 || 60 < name->len || strchr(name->buf, '@') ||
 		strchr(name->buf, '<') || strchr(name->buf, '>'))
 		src = email;
 	else if (name == out)
-- 
1.6.3.3.18.g49902.dirty
Oswald Buddenhagen· Jul 29, 2009, 14:55 UTC · re: Oswald Buddenhagen · lore

Re: [PATCH] Allow author names with just two letters.

moin,

just in case this wasn't clear: the patch below is a request to merge, or at least an rfc. you see, i have a rather bad standing in getting my colleagues to use rebase if git mangles their commits in the process. ;) thanks

greetings
On Fri, Jul 10, 2009 at 10:01:34PM +0200, Oswald Buddenhagen wrote:
Show 24 quoted lines
> Some at Qt Software use aliases which may have only two letters.
> 
> One could argue that just one letter should be permitted as well,
> but that's none of my concerns. :)
> ---
>  builtin-mailinfo.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/builtin-mailinfo.c b/builtin-mailinfo.c
> index 1eeeb4d..1adbebd 100644
> --- a/builtin-mailinfo.c
> +++ b/builtin-mailinfo.c
> @@ -35,7 +35,7 @@ static void cleanup_space(struct strbuf *sb);
>  static void get_sane_name(struct strbuf *out, struct strbuf *name, struct strbuf *email)
>  {
>  	struct strbuf *src = name;
> -	if (name->len < 3 || 60 < name->len || strchr(name->buf, '@') ||
> +	if (name->len < 2 || 60 < name->len || strchr(name->buf, '@') ||
>  		strchr(name->buf, '<') || strchr(name->buf, '>'))
>  		src = email;
>  	else if (name == out)
> -- 
> 1.6.3.3.18.g49902.dirty
> 

← back to recent threads